From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] Add dwarf to last_source_file comment.
Date: Sat, 05 Apr 2008 09:11:00 -0000 [thread overview]
Message-ID: <20080404230816.B032E1C755A@localhost> (raw)
Ok to check in?
2008-04-04 Doug Evans <dje@google.com>
* buildsym.h (last_source_file): Add dwarf info to comment.
(last_source_start_addr): Ditto.
Index: buildsym.h
===================================================================
RCS file: /cvs/src/src/gdb/buildsym.h,v
retrieving revision 1.20
diff -u -p -u -p -r1.20 buildsym.h
--- buildsym.h 1 Jan 2008 22:53:09 -0000 1.20
+++ buildsym.h 4 Apr 2008 23:07:20 -0000
@@ -47,12 +47,14 @@ struct block;
hashname() */
/* Name of source file whose symbol data we are now processing. This
- comes from a symbol of type N_SO. */
+ comes from a symbol of type N_SO for stabs. For Dwarf it comes from the
+ DW_AT_name attribute of a DW_TAG_compile_unit DIE. */
EXTERN char *last_source_file;
/* Core address of start of text of current source file. This too
- comes from the N_SO symbol. */
+ comes from the N_SO symbol. For Dwarf it typically comes from the
+ DW_AT_low_pc attribute of a DW_TAG_compile_unit DIE. */
EXTERN CORE_ADDR last_source_start_addr;
next reply other threads:[~2008-04-04 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 9:11 Doug Evans [this message]
2008-04-05 9:29 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080404230816.B032E1C755A@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox