From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25379 invoked by alias); 4 Apr 2008 23:08:44 -0000 Received: (qmail 25369 invoked by uid 22791); 4 Apr 2008 23:08:43 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Apr 2008 23:08:24 +0000 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id m34N8Hxw026770 for ; Sat, 5 Apr 2008 00:08:18 +0100 Received: from localhost (ruffy.corp.google.com [172.18.118.116]) by zps37.corp.google.com with ESMTP id m34N8GOJ006516 for ; Fri, 4 Apr 2008 16:08:17 -0700 Received: by localhost (Postfix, from userid 67641) id B032E1C755A; Fri, 4 Apr 2008 16:08:16 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [RFA] Add dwarf to last_source_file comment. Message-Id: <20080404230816.B032E1C755A@localhost> Date: Sat, 05 Apr 2008 09:11:00 -0000 From: dje@google.com (Doug Evans) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00114.txt.bz2 Ok to check in? 2008-04-04 Doug Evans * buildsym.h (last_source_file): Add dwarf info to comment. (last_source_start_addr): Ditto. Index: buildsym.h =================================================================== RCS file: /cvs/src/src/gdb/buildsym.h,v retrieving revision 1.20 diff -u -p -u -p -r1.20 buildsym.h --- buildsym.h 1 Jan 2008 22:53:09 -0000 1.20 +++ buildsym.h 4 Apr 2008 23:07:20 -0000 @@ -47,12 +47,14 @@ struct block; hashname() */ /* Name of source file whose symbol data we are now processing. This - comes from a symbol of type N_SO. */ + comes from a symbol of type N_SO for stabs. For Dwarf it comes from the + DW_AT_name attribute of a DW_TAG_compile_unit DIE. */ EXTERN char *last_source_file; /* Core address of start of text of current source file. This too - comes from the N_SO symbol. */ + comes from the N_SO symbol. For Dwarf it typically comes from the + DW_AT_low_pc attribute of a DW_TAG_compile_unit DIE. */ EXTERN CORE_ADDR last_source_start_addr;