Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info
@ 2008-03-13 10:27 Markus Deuling
  2008-03-17 19:21 ` Ulrich Weigand
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Deuling @ 2008-03-13 10:27 UTC (permalink / raw)
  To: GDB Patches; +Cc: Ulrich Weigand

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi,

this patch removes a call to gdbarch_bfd_arch_info which is unnecessary, as 
bfd_mach value was set before in every case. Testsuite showed no regressions on x86.

Ok ?

ChangeLog:

	* i386-tdep.c (i386_print_insn): Remove unnecessary call to
	gdbarch_bfd_arch_info.

-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com


[-- Attachment #2: diff-i386-dis --]
[-- Type: text/plain, Size: 530 bytes --]

diff -urpN src/gdb/i386-tdep.c dev/gdb/i386-tdep.c
--- src/gdb/i386-tdep.c	2008-03-11 06:21:52.000000000 +0100
+++ dev/gdb/i386-tdep.c	2008-03-13 09:13:35.000000000 +0100
@@ -2138,7 +2138,6 @@ i386_print_insn (bfd_vma pc, struct disa
   /* FIXME: kettenis/20020915: Until disassembler_options is properly
      constified, cast to prevent a compiler warning.  */
   info->disassembler_options = (char *) disassembly_flavor;
-  info->mach = gdbarch_bfd_arch_info (current_gdbarch)->mach;
 
   return print_insn_i386 (pc, info);
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info
  2008-03-13 10:27 [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info Markus Deuling
@ 2008-03-17 19:21 ` Ulrich Weigand
  2008-03-17 19:34   ` Markus Deuling
  0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Weigand @ 2008-03-17 19:21 UTC (permalink / raw)
  To: Markus Deuling; +Cc: GDB Patches

Markus Deuling wrote:

> 	* i386-tdep.c (i386_print_insn): Remove unnecessary call to
> 	gdbarch_bfd_arch_info.

This looks good to me.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info
  2008-03-17 19:21 ` Ulrich Weigand
@ 2008-03-17 19:34   ` Markus Deuling
  0 siblings, 0 replies; 3+ messages in thread
From: Markus Deuling @ 2008-03-17 19:34 UTC (permalink / raw)
  To: Ulrich Weigand; +Cc: Markus Deuling, GDB Patches

Ulrich Weigand schrieb:
> Markus Deuling wrote:
> 
>> 	* i386-tdep.c (i386_print_insn): Remove unnecessary call to
>> 	gdbarch_bfd_arch_info.
> 
> This looks good to me.
> 
Thank you, I've committed it.

Regards,
Markus

-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-17 19:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-13 10:27 [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info Markus Deuling
2008-03-17 19:21 ` Ulrich Weigand
2008-03-17 19:34   ` Markus Deuling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox