From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>
Subject: [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info
Date: Thu, 13 Mar 2008 10:27:00 -0000 [thread overview]
Message-ID: <47D9016F.7000105@de.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi,
this patch removes a call to gdbarch_bfd_arch_info which is unnecessary, as
bfd_mach value was set before in every case. Testsuite showed no regressions on x86.
Ok ?
ChangeLog:
* i386-tdep.c (i386_print_insn): Remove unnecessary call to
gdbarch_bfd_arch_info.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
[-- Attachment #2: diff-i386-dis --]
[-- Type: text/plain, Size: 530 bytes --]
diff -urpN src/gdb/i386-tdep.c dev/gdb/i386-tdep.c
--- src/gdb/i386-tdep.c 2008-03-11 06:21:52.000000000 +0100
+++ dev/gdb/i386-tdep.c 2008-03-13 09:13:35.000000000 +0100
@@ -2138,7 +2138,6 @@ i386_print_insn (bfd_vma pc, struct disa
/* FIXME: kettenis/20020915: Until disassembler_options is properly
constified, cast to prevent a compiler warning. */
info->disassembler_options = (char *) disassembly_flavor;
- info->mach = gdbarch_bfd_arch_info (current_gdbarch)->mach;
return print_insn_i386 (pc, info);
}
next reply other threads:[~2008-03-13 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 10:27 Markus Deuling [this message]
2008-03-17 19:21 ` Ulrich Weigand
2008-03-17 19:34 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D9016F.7000105@de.ibm.com \
--to=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox