From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31051 invoked by alias); 13 Mar 2008 10:27:35 -0000 Received: (qmail 31040 invoked by uid 22791); 13 Mar 2008 10:27:34 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 13 Mar 2008 10:27:05 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2DAQusS148536 for ; Thu, 13 Mar 2008 10:26:56 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2DAQuUU1822920 for ; Thu, 13 Mar 2008 11:26:56 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2DAQu5G004195 for ; Thu, 13 Mar 2008 11:26:56 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2DAQtiL004173 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Mar 2008 11:26:56 +0100 Message-ID: <47D9016F.7000105@de.ibm.com> Date: Thu, 13 Mar 2008 10:27:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: [rfc]: Remove unnecessary call to gdbarch_bfd_arch_info Content-Type: multipart/mixed; boundary="------------010301010301030805080706" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00140.txt.bz2 This is a multi-part message in MIME format. --------------010301010301030805080706 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 352 Hi, this patch removes a call to gdbarch_bfd_arch_info which is unnecessary, as bfd_mach value was set before in every case. Testsuite showed no regressions on x86. Ok ? ChangeLog: * i386-tdep.c (i386_print_insn): Remove unnecessary call to gdbarch_bfd_arch_info. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------010301010301030805080706 Content-Type: text/plain; name="diff-i386-dis" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-i386-dis" Content-length: 530 diff -urpN src/gdb/i386-tdep.c dev/gdb/i386-tdep.c --- src/gdb/i386-tdep.c 2008-03-11 06:21:52.000000000 +0100 +++ dev/gdb/i386-tdep.c 2008-03-13 09:13:35.000000000 +0100 @@ -2138,7 +2138,6 @@ i386_print_insn (bfd_vma pc, struct disa /* FIXME: kettenis/20020915: Until disassembler_options is properly constified, cast to prevent a compiler warning. */ info->disassembler_options = (char *) disassembly_flavor; - info->mach = gdbarch_bfd_arch_info (current_gdbarch)->mach; return print_insn_i386 (pc, info); } --------------010301010301030805080706--