[patch] Fix "directory" command problem under "set confirm off"

[patch] Fix "directory" command problem under "set confirm off"

[Hidetaka Takano]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi maintainer,

I'll send the patch to fix the "directory" command problem.

When the directory command is issued without any parameters,
the source search path is supposed to be initialized.
But it doesn't work under "set confirm off".


ChangeLog:

2008-03-06  Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>

	* source.c (directory_command): modify the determination of
	condition of terminal "from_tty".

Best regard.
---
Hidetaka Takano / Toshiba

[-- Attachment #2: fix-directory-confirm-off2.diff --]
[-- Type: application/octet-stream, Size: 514 bytes --]

diff -urpN src-org/gdb/source.c src/gdb/source.c
--- src-org/gdb/source.c	2008-02-09 07:20:48.000000000 +0900
+++ src/gdb/source.c	2008-03-04 13:33:58.000000000 +0900
@@ -369,7 +369,7 @@ directory_command (char *dirname, int fr
   /* FIXME, this goes to "delete dir"... */
   if (dirname == 0)
     {
-      if (from_tty && query (_("Reinitialize source path to empty? ")))
+      if (!from_tty || query (_("Reinitialize source path to empty? ")))
 	{
 	  xfree (source_path);
 	  init_source_path ();

Re: [patch] Fix "directory" command problem under "set confirm off"

[Michael Snyder]

On Thu, 2008-03-06 at 21:39 +0900, Hidetaka Takano wrote:
> Hi maintainer,
> 
> I'll send the patch to fix the "directory" command problem.
> 
> When the directory command is issued without any parameters,
> the source search path is supposed to be initialized.
> But it doesn't work under "set confirm off".

Hey, you're right!  And it doesn't work for batch files, either.
Your patch fixes both.

Do you have a copyright assignment on file?

Since this is a one-line fix, I can check it in for you
(if you wish), but if you're going to be submitting more
patches, you might want to do the paperwork.

> 
> 
> ChangeLog:
> 
> 2008-03-06  Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
> 
> 	* source.c (directory_command): modify the determination of
> 	condition of terminal "from_tty".
> 
> Best regard.
> ---
> Hidetaka Takano / Toshiba

RE: [patch] Fix "directory" command problem under "set confirm off"

[Hidetaka Takano]

Hi Michael,

> Do you have a copyright assignment on file?

Yes, I've already done it as Toshiba corp.

Is there anything special to be required to send a patch?
 ex) need proof?

Best regard.

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org 
> [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Michael Snyder
> Sent: Friday, March 07, 2008 5:47 AM
> To: Hidetaka Takano
> Cc: gdb-patches@sourceware.org
> Subject: Re: [patch] Fix "directory" command problem under 
> "set confirm off"
> 
> On Thu, 2008-03-06 at 21:39 +0900, Hidetaka Takano wrote:
> > Hi maintainer,
> > 
> > I'll send the patch to fix the "directory" command problem.
> > 
> > When the directory command is issued without any parameters,
> > the source search path is supposed to be initialized.
> > But it doesn't work under "set confirm off".
> 
> Hey, you're right!  And it doesn't work for batch files, either.
> Your patch fixes both.
> 
> Do you have a copyright assignment on file?
> 
> Since this is a one-line fix, I can check it in for you
> (if you wish), but if you're going to be submitting more
> patches, you might want to do the paperwork.
> 
> > 
> > 
> > ChangeLog:
> > 
> > 2008-03-06  Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
> > 
> > 	* source.c (directory_command): modify the determination of
> > 	condition of terminal "from_tty".
> > 
> > Best regard.
> > ---
> > Hidetaka Takano / Toshiba
> 

Re: [patch] Fix "directory" command problem under "set confirm off"

[Ulrich Weigand]

Michael,

> > Do you have a copyright assignment on file?
> 
> Yes, I've already done it as Toshiba corp.
> 
> Is there anything special to be required to send a patch?
>  ex) need proof?

The GNU copyright.list has an entry for assignment of
past and future changes to GDB by Toshiba Corporation.
I think that should be sufficient, right?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [patch] Fix "directory" command problem under "set confirm off"

[Daniel Jacobowitz]

On Mon, Mar 10, 2008 at 01:34:56PM +0100, Ulrich Weigand wrote:
> Michael,
> 
> > > Do you have a copyright assignment on file?
> > 
> > Yes, I've already done it as Toshiba corp.
> > 
> > Is there anything special to be required to send a patch?
> >  ex) need proof?
> 
> The GNU copyright.list has an entry for assignment of
> past and future changes to GDB by Toshiba Corporation.
> I think that should be sufficient, right?

Yes, that's sufficient.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [patch] Fix "directory" command problem under "set confirm off"

[Michael Snyder]

On Mon, 2008-03-10 at 08:47 -0400, Daniel Jacobowitz wrote:
> On Mon, Mar 10, 2008 at 01:34:56PM +0100, Ulrich Weigand wrote:
> > Michael,
> > 
> > > > Do you have a copyright assignment on file?
> > > 
> > > Yes, I've already done it as Toshiba corp.
> > > 
> > > Is there anything special to be required to send a patch?
> > >  ex) need proof?
> > 
> > The GNU copyright.list has an entry for assignment of
> > past and future changes to GDB by Toshiba Corporation.
> > I think that should be sufficient, right?
> 
> Yes, that's sufficient.

All right then, committed.
Thank you, Takano-san!