Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@specifix.com>
To: Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix "directory" command problem under "set confirm off"
Date: Thu, 06 Mar 2008 20:47:00 -0000	[thread overview]
Message-ID: <1204836425.19253.694.camel@localhost.localdomain> (raw)
In-Reply-To: <002901c87f87$12218bc0$f61e4f9d@MOSTPCMSS20377>

On Thu, 2008-03-06 at 21:39 +0900, Hidetaka Takano wrote:
> Hi maintainer,
> 
> I'll send the patch to fix the "directory" command problem.
> 
> When the directory command is issued without any parameters,
> the source search path is supposed to be initialized.
> But it doesn't work under "set confirm off".

Hey, you're right!  And it doesn't work for batch files, either.
Your patch fixes both.

Do you have a copyright assignment on file?

Since this is a one-line fix, I can check it in for you
(if you wish), but if you're going to be submitting more
patches, you might want to do the paperwork.

> 
> 
> ChangeLog:
> 
> 2008-03-06  Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
> 
> 	* source.c (directory_command): modify the determination of
> 	condition of terminal "from_tty".
> 
> Best regard.
> ---
> Hidetaka Takano / Toshiba


  reply	other threads:[~2008-03-06 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 12:39 Hidetaka Takano
2008-03-06 20:47 ` Michael Snyder [this message]
2008-03-10  3:06   ` Hidetaka Takano
2008-03-10 12:35     ` Ulrich Weigand
2008-03-10 12:47       ` Daniel Jacobowitz
2008-03-10 20:54         ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204836425.19253.694.camel@localhost.localdomain \
    --to=msnyder@specifix.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hidetaka.takano@glb.toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox