From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54399-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4944 invoked by alias); 6 Mar 2008 20:47:25 -0000
Received: (qmail 4934 invoked by uid 22791); 6 Mar 2008 20:47:24 -0000
X-Spam-Check-By: sourceware.org
Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 06 Mar 2008 20:47:07 +0000
Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) 	by bluesmobile.specifix.com (Postfix) with ESMTP id 0AFAC3C564; 	Thu,  6 Mar 2008 12:47:05 -0800 (PST)
Subject: Re: [patch] Fix "directory" command problem under "set confirm off"
From: Michael Snyder <msnyder@specifix.com>
To: Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
Cc: gdb-patches@sourceware.org
In-Reply-To: <002901c87f87$12218bc0$f61e4f9d@MOSTPCMSS20377>
References: <002901c87f87$12218bc0$f61e4f9d@MOSTPCMSS20377>
Content-Type: text/plain
Date: Thu, 06 Mar 2008 20:47:00 -0000
Message-Id: <1204836425.19253.694.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7)
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-03/txt/msg00041.txt.bz2

On Thu, 2008-03-06 at 21:39 +0900, Hidetaka Takano wrote:
> Hi maintainer,
> 
> I'll send the patch to fix the "directory" command problem.
> 
> When the directory command is issued without any parameters,
> the source search path is supposed to be initialized.
> But it doesn't work under "set confirm off".

Hey, you're right!  And it doesn't work for batch files, either.
Your patch fixes both.

Do you have a copyright assignment on file?

Since this is a one-line fix, I can check it in for you
(if you wish), but if you're going to be submitting more
patches, you might want to do the paperwork.

> 
> 
> ChangeLog:
> 
> 2008-03-06  Hidetaka Takano <hidetaka.takano@glb.toshiba.co.jp>
> 
> 	* source.c (directory_command): modify the determination of
> 	condition of terminal "from_tty".
> 
> Best regard.
> ---
> Hidetaka Takano / Toshiba