Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] tighten constraints in patterns in maint.exp testcase
@ 2008-01-18  8:18 Doug Evans
  2008-01-18 15:32 ` Daniel Jacobowitz
  0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2008-01-18  8:18 UTC (permalink / raw)
  To: gdb-patches

I happened to run the testsuite in a directory that had "data" in the name,
and it caused "maint info sections .text" to fail.

OK to check in?

2008-01-18  Doug Evans  <dje@google.com>

	* maint.exp: Tighten patterns looking for .text/.data/.bss.

Index: maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.32
diff -u -p -u -p -r1.32 maint.exp
--- maint.exp	1 Jan 2008 22:53:19 -0000	1.32
+++ maint.exp	18 Jan 2008 08:11:33 -0000
@@ -448,9 +448,9 @@ gdb_expect  {
 # If you don't have a .text section, this will require tweaking.
 send_gdb "maint info sections .text\n"
 gdb_expect {
-    -re ".*bss.*$gdb_prompt $"      { fail "maint info sections .text" }
-    -re ".*data.*$gdb_prompt $"     { fail "maint info sections .text" }
-    -re ".* .text .*$gdb_prompt $"  { pass "maint info sections .text" }
+    -re ".* \\.bss .*$gdb_prompt $"      { fail "maint info sections .text" }
+    -re ".* \\.data .*$gdb_prompt $"     { fail "maint info sections .text" }
+    -re ".* \\.text .*$gdb_prompt $"  { pass "maint info sections .text" }
     -re ".*$gdb_prompt $"           { fail "maint info sections .text" }
     timeout               { fail "(timeout) maint info sections .text" }
 }
@@ -459,8 +459,8 @@ gdb_expect {
 # If your data section is tagged CODE, xfail this test.
 send_gdb "maint info sections CODE\n"
 gdb_expect {
-    -re ".* .data .*$gdb_prompt $" { fail "maint info sections CODE" }
-    -re ".* .text .*$gdb_prompt $" { pass "maint info sections CODE" }
+    -re ".* \\.data .*$gdb_prompt $" { fail "maint info sections CODE" }
+    -re ".* \\.text .*$gdb_prompt $" { pass "maint info sections CODE" }
     -re ".*$gdb_prompt $"          { fail "maint info sections CODE" }
     timeout              { fail "(timeout) maint info sections CODE" }
 }
@@ -473,8 +473,8 @@ gdb_expect {
 setup_xfail "*-*-*cygwin*"
 send_gdb "maint info sections DATA\n"
 gdb_expect {
-    -re ".* .text .*$gdb_prompt $" { fail "maint info sections DATA" }
-    -re ".* .data .*$gdb_prompt $" { pass "maint info sections DATA" }
+    -re ".* \\.text .*$gdb_prompt $" { fail "maint info sections DATA" }
+    -re ".* \\.data .*$gdb_prompt $" { pass "maint info sections DATA" }
     -re ".*$gdb_prompt $"          { fail "maint info sections DATA" }
     timeout              { fail "(timeout) maint info sections DATA" }
 }


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA] tighten constraints in patterns in maint.exp testcase
  2008-01-18  8:18 [RFA] tighten constraints in patterns in maint.exp testcase Doug Evans
@ 2008-01-18 15:32 ` Daniel Jacobowitz
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2008-01-18 15:32 UTC (permalink / raw)
  To: Doug Evans; +Cc: gdb-patches

On Fri, Jan 18, 2008 at 12:17:30AM -0800, Doug Evans wrote:
> I happened to run the testsuite in a directory that had "data" in the name,
> and it caused "maint info sections .text" to fail.
> 
> OK to check in?
> 
> 2008-01-18  Doug Evans  <dje@google.com>
> 
> 	* maint.exp: Tighten patterns looking for .text/.data/.bss.

OK.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-18 15:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-18  8:18 [RFA] tighten constraints in patterns in maint.exp testcase Doug Evans
2008-01-18 15:32 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox