From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23148 invoked by alias); 18 Jan 2008 08:18:06 -0000 Received: (qmail 23130 invoked by uid 22791); 18 Jan 2008 08:18:05 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 18 Jan 2008 08:17:45 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id m0I8HfZO017658 for ; Fri, 18 Jan 2008 00:17:41 -0800 Received: from localhost (ruffy.corp.google.com [172.18.118.116]) by zps76.corp.google.com with ESMTP id m0I8Hec9012003 for ; Fri, 18 Jan 2008 00:17:41 -0800 Received: by localhost (Postfix, from userid 67641) id AC8941C7247; Fri, 18 Jan 2008 00:17:30 -0800 (PST) To: gdb-patches@sourceware.org Subject: [RFA] tighten constraints in patterns in maint.exp testcase Message-Id: <20080118081730.AC8941C7247@localhost> Date: Fri, 18 Jan 2008 08:18:00 -0000 From: dje@google.com (Doug Evans) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00468.txt.bz2 I happened to run the testsuite in a directory that had "data" in the name, and it caused "maint info sections .text" to fail. OK to check in? 2008-01-18 Doug Evans * maint.exp: Tighten patterns looking for .text/.data/.bss. Index: maint.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v retrieving revision 1.32 diff -u -p -u -p -r1.32 maint.exp --- maint.exp 1 Jan 2008 22:53:19 -0000 1.32 +++ maint.exp 18 Jan 2008 08:11:33 -0000 @@ -448,9 +448,9 @@ gdb_expect { # If you don't have a .text section, this will require tweaking. send_gdb "maint info sections .text\n" gdb_expect { - -re ".*bss.*$gdb_prompt $" { fail "maint info sections .text" } - -re ".*data.*$gdb_prompt $" { fail "maint info sections .text" } - -re ".* .text .*$gdb_prompt $" { pass "maint info sections .text" } + -re ".* \\.bss .*$gdb_prompt $" { fail "maint info sections .text" } + -re ".* \\.data .*$gdb_prompt $" { fail "maint info sections .text" } + -re ".* \\.text .*$gdb_prompt $" { pass "maint info sections .text" } -re ".*$gdb_prompt $" { fail "maint info sections .text" } timeout { fail "(timeout) maint info sections .text" } } @@ -459,8 +459,8 @@ gdb_expect { # If your data section is tagged CODE, xfail this test. send_gdb "maint info sections CODE\n" gdb_expect { - -re ".* .data .*$gdb_prompt $" { fail "maint info sections CODE" } - -re ".* .text .*$gdb_prompt $" { pass "maint info sections CODE" } + -re ".* \\.data .*$gdb_prompt $" { fail "maint info sections CODE" } + -re ".* \\.text .*$gdb_prompt $" { pass "maint info sections CODE" } -re ".*$gdb_prompt $" { fail "maint info sections CODE" } timeout { fail "(timeout) maint info sections CODE" } } @@ -473,8 +473,8 @@ gdb_expect { setup_xfail "*-*-*cygwin*" send_gdb "maint info sections DATA\n" gdb_expect { - -re ".* .text .*$gdb_prompt $" { fail "maint info sections DATA" } - -re ".* .data .*$gdb_prompt $" { pass "maint info sections DATA" } + -re ".* \\.text .*$gdb_prompt $" { fail "maint info sections DATA" } + -re ".* \\.data .*$gdb_prompt $" { pass "maint info sections DATA" } -re ".*$gdb_prompt $" { fail "maint info sections DATA" } timeout { fail "(timeout) maint info sections DATA" } }