Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] tighten constraints in patterns in maint.exp testcase
Date: Fri, 18 Jan 2008 08:18:00 -0000	[thread overview]
Message-ID: <20080118081730.AC8941C7247@localhost> (raw)

I happened to run the testsuite in a directory that had "data" in the name,
and it caused "maint info sections .text" to fail.

OK to check in?

2008-01-18  Doug Evans  <dje@google.com>

	* maint.exp: Tighten patterns looking for .text/.data/.bss.

Index: maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.32
diff -u -p -u -p -r1.32 maint.exp
--- maint.exp	1 Jan 2008 22:53:19 -0000	1.32
+++ maint.exp	18 Jan 2008 08:11:33 -0000
@@ -448,9 +448,9 @@ gdb_expect  {
 # If you don't have a .text section, this will require tweaking.
 send_gdb "maint info sections .text\n"
 gdb_expect {
-    -re ".*bss.*$gdb_prompt $"      { fail "maint info sections .text" }
-    -re ".*data.*$gdb_prompt $"     { fail "maint info sections .text" }
-    -re ".* .text .*$gdb_prompt $"  { pass "maint info sections .text" }
+    -re ".* \\.bss .*$gdb_prompt $"      { fail "maint info sections .text" }
+    -re ".* \\.data .*$gdb_prompt $"     { fail "maint info sections .text" }
+    -re ".* \\.text .*$gdb_prompt $"  { pass "maint info sections .text" }
     -re ".*$gdb_prompt $"           { fail "maint info sections .text" }
     timeout               { fail "(timeout) maint info sections .text" }
 }
@@ -459,8 +459,8 @@ gdb_expect {
 # If your data section is tagged CODE, xfail this test.
 send_gdb "maint info sections CODE\n"
 gdb_expect {
-    -re ".* .data .*$gdb_prompt $" { fail "maint info sections CODE" }
-    -re ".* .text .*$gdb_prompt $" { pass "maint info sections CODE" }
+    -re ".* \\.data .*$gdb_prompt $" { fail "maint info sections CODE" }
+    -re ".* \\.text .*$gdb_prompt $" { pass "maint info sections CODE" }
     -re ".*$gdb_prompt $"          { fail "maint info sections CODE" }
     timeout              { fail "(timeout) maint info sections CODE" }
 }
@@ -473,8 +473,8 @@ gdb_expect {
 setup_xfail "*-*-*cygwin*"
 send_gdb "maint info sections DATA\n"
 gdb_expect {
-    -re ".* .text .*$gdb_prompt $" { fail "maint info sections DATA" }
-    -re ".* .data .*$gdb_prompt $" { pass "maint info sections DATA" }
+    -re ".* \\.text .*$gdb_prompt $" { fail "maint info sections DATA" }
+    -re ".* \\.data .*$gdb_prompt $" { pass "maint info sections DATA" }
     -re ".*$gdb_prompt $"          { fail "maint info sections DATA" }
     timeout              { fail "(timeout) maint info sections DATA" }
 }


             reply	other threads:[~2008-01-18  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  8:18 Doug Evans [this message]
2008-01-18 15:32 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080118081730.AC8941C7247@localhost \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox