[gdbserver] (9/11) Relax the pid format

[gdbserver] (9/11) Relax the pid format

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Hi,

On Windows CE the PIDs are really handles, so they are
most frequently represented in hex.  Only accepting decimal
on the --attach command line argument is a bit annoying.

Would it be ok to relax the bases supported ?

Cheers,
Pedro Alves



[-- Attachment #2: gdbserver_attach_pid.diff --]
[-- Type: text/x-diff, Size: 732 bytes --]

2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>

	* server.c (main): Relax numerical bases supported for the pid of
	the --attach command line argument.

---
 gdb/gdbserver/server.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/gdbserver/server.c
===================================================================
--- src.orig/gdb/gdbserver/server.c	2007-11-11 23:12:50.000000000 +0000
+++ src/gdb/gdbserver/server.c	2007-11-11 23:16:20.000000000 +0000
@@ -875,7 +875,7 @@ main (int argc, char *argv[])
     {
       if (argc == 4
 	  && argv[3][0] != '\0'
-	  && (pid = strtoul (argv[3], &arg_end, 10)) != 0
+	  && (pid = strtoul (argv[3], &arg_end, 0)) != 0
 	  && *arg_end == '\0')
 	{
 	  ;

Re: [gdbserver] (9/11) Relax the pid format

[Daniel Jacobowitz]

On Mon, Nov 12, 2007 at 02:08:38AM +0000, Pedro Alves wrote:
> 2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>
> 
> 	* server.c (main): Relax numerical bases supported for the pid of
> 	the --attach command line argument.

Sure, this is OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [gdbserver] (9/11) Relax the pid format

[Pedro Alves]

Daniel Jacobowitz wrote:
> On Mon, Nov 12, 2007 at 02:08:38AM +0000, Pedro Alves wrote:
>> 2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>
>>
>> 	* server.c (main): Relax numerical bases supported for the pid of
>> 	the --attach command line argument.
> 
> Sure, this is OK.
> 


Thank you.  Checked in.

-- 
Pedro Alves