From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1288 invoked by alias); 12 Nov 2007 02:08:43 -0000 Received: (qmail 1277 invoked by uid 22791); 12 Nov 2007 02:08:43 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.173) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 12 Nov 2007 02:08:40 +0000 Received: by ug-out-1314.google.com with SMTP id o2so756215uge for ; Sun, 11 Nov 2007 18:08:40 -0800 (PST) Received: by 10.66.238.16 with SMTP id l16mr1245391ugh.1194833318862; Sun, 11 Nov 2007 18:08:38 -0800 (PST) Received: from ?192.168.0.4? ( [62.169.107.97]) by mx.google.com with ESMTPS id l4sm3922429ugf.2007.11.11.18.08.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 11 Nov 2007 18:08:37 -0800 (PST) Message-ID: <4737B5A6.7090706@portugalmail.pt> Date: Mon, 12 Nov 2007 02:08:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org, Lerele Subject: [gdbserver] (9/11) Relax the pid format Content-Type: multipart/mixed; boundary="------------060201050908080103030703" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00222.txt.bz2 This is a multi-part message in MIME format. --------------060201050908080103030703 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 247 Hi, On Windows CE the PIDs are really handles, so they are most frequently represented in hex. Only accepting decimal on the --attach command line argument is a bit annoying. Would it be ok to relax the bases supported ? Cheers, Pedro Alves --------------060201050908080103030703 Content-Type: text/x-diff; name="gdbserver_attach_pid.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gdbserver_attach_pid.diff" Content-length: 732 2007-11-12 Pedro Alves * server.c (main): Relax numerical bases supported for the pid of the --attach command line argument. --- gdb/gdbserver/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: src/gdb/gdbserver/server.c =================================================================== --- src.orig/gdb/gdbserver/server.c 2007-11-11 23:12:50.000000000 +0000 +++ src/gdb/gdbserver/server.c 2007-11-11 23:16:20.000000000 +0000 @@ -875,7 +875,7 @@ main (int argc, char *argv[]) { if (argc == 4 && argv[3][0] != '\0' - && (pid = strtoul (argv[3], &arg_end, 10)) != 0 + && (pid = strtoul (argv[3], &arg_end, 0)) != 0 && *arg_end == '\0') { ; --------------060201050908080103030703--