Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro_alves@portugalmail.pt>
To: gdb-patches@sourceware.org, Lerele <lerele@champenstudios.com>
Subject: [gdbserver] (9/11) Relax the pid format
Date: Mon, 12 Nov 2007 02:08:00 -0000	[thread overview]
Message-ID: <4737B5A6.7090706@portugalmail.pt> (raw)

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Hi,

On Windows CE the PIDs are really handles, so they are
most frequently represented in hex.  Only accepting decimal
on the --attach command line argument is a bit annoying.

Would it be ok to relax the bases supported ?

Cheers,
Pedro Alves



[-- Attachment #2: gdbserver_attach_pid.diff --]
[-- Type: text/x-diff, Size: 732 bytes --]

2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>

	* server.c (main): Relax numerical bases supported for the pid of
	the --attach command line argument.

---
 gdb/gdbserver/server.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/gdbserver/server.c
===================================================================
--- src.orig/gdb/gdbserver/server.c	2007-11-11 23:12:50.000000000 +0000
+++ src/gdb/gdbserver/server.c	2007-11-11 23:16:20.000000000 +0000
@@ -875,7 +875,7 @@ main (int argc, char *argv[])
     {
       if (argc == 4
 	  && argv[3][0] != '\0'
-	  && (pid = strtoul (argv[3], &arg_end, 10)) != 0
+	  && (pid = strtoul (argv[3], &arg_end, 0)) != 0
 	  && *arg_end == '\0')
 	{
 	  ;



             reply	other threads:[~2007-11-12  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12  2:08 Pedro Alves [this message]
2007-12-01 19:01 ` Daniel Jacobowitz
2007-12-03  3:53   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4737B5A6.7090706@portugalmail.pt \
    --to=pedro_alves@portugalmail.pt \
    --cc=gdb-patches@sourceware.org \
    --cc=lerele@champenstudios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox