From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>,
gdb-patches@sources.redhat.com
Subject: Re: [patch] XLF Fortran: Remove an inappropriate complaint [Re: XLF Fortran arrays test]
Date: Sun, 25 Nov 2007 14:56:00 -0000 [thread overview]
Message-ID: <20071125145555.GB30778@caradoc.them.org> (raw)
In-Reply-To: <20071123172104.GA23776@host0.dyn.jankratochvil.net>
On Fri, Nov 23, 2007 at 06:21:04PM +0100, Jan Kratochvil wrote:
> On Fri, 23 Nov 2007 18:05:48 +0100, Carlos Eduardo Seo wrote:
> ...
> > The only strange behavior is that when I set a breakpoint, I get this
> > message:
> >
> > During symbol reading, DW_AT_type missing from DW_TAG_subrange_type.
>
> This code was there already before my changes. And the XLF output really
> misses DW_AT_type for DW_TAG_subrange_type. But it should be correct:
> http://dwarf.freestandards.org/Dwarf3.pdf
> 5.12 Subrange Type Entries
> The subrange entry may have a DW_AT_type attribute to describe the type
> of object, called the basis type, of whose values this subrange is
> a subset.
>
> "may have" should not produce a `complaint' category message as it is not
> a standard violation.
>
> Providing a patch but I do not know much more about it.
Here's the rest of what the standard has to say:
==
If the subrange entry has no type attribute describing the basis type,
the basis type is assumed to be the same as the object described by
the lower bound attribute (if it references an object). If there is no
lower bound attribute, or that attribute does not reference an object,
the basis type is the type of the upper bound or count attribute (if
either of them references an object). If there is no upper bound or
count attribute, or neither references an object, the type is assumed
to be the same type, in the source language of the compilation unit
containing the subrange entry, as a signed integer with the same size
as an address on the target machine.
==
It looks to me like (before your other patches?) we do not support
the bounds or count referring to objects. The code below the
complaint is creating a signed integer type the size of an address.
So your patch is OK. Thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-25 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 3:20 [00/11] Fortran dynamic arrays support Jan Kratochvil
2007-11-16 17:46 ` Jim Blandy
2007-11-16 17:55 ` Carlos Eduardo Seo
2007-11-16 19:45 ` Jan Kratochvil
2007-11-19 14:41 ` Carlos Eduardo Seo
[not found] ` <20071123015957.GA3202@host0.dyn.jankratochvil.net>
[not found] ` <20071123021120.GA11797@host0.dyn.jankratochvil.net>
[not found] ` <20071123163125.GA23275@host0.dyn.jankratochvil.net>
[not found] ` <4747086C.3070100@linux.vnet.ibm.com>
2007-11-23 17:21 ` [patch] XLF Fortran: Remove an inappropriate complaint [Re: XLF Fortran arrays test] Jan Kratochvil
2007-11-25 14:56 ` Daniel Jacobowitz [this message]
2007-11-25 22:11 ` Jan Kratochvil
2007-11-25 22:14 ` Daniel Jacobowitz
2007-11-26 7:20 ` [patch] XLF Fortran: Remove an inappropriate complaint Jan Kratochvil
2007-11-26 13:26 ` Daniel Jacobowitz
2007-11-26 22:07 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071125145555.GB30778@caradoc.them.org \
--to=drow@false.org \
--cc=cseo@linux.vnet.ibm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox