From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14933 invoked by alias); 25 Nov 2007 14:56:06 -0000 Received: (qmail 14925 invoked by uid 22791); 25 Nov 2007 14:56:06 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 25 Nov 2007 14:55:58 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8839A98349; Sun, 25 Nov 2007 14:55:56 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 3091B980A5; Sun, 25 Nov 2007 14:55:56 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IwItn-0008Dn-Bo; Sun, 25 Nov 2007 09:55:55 -0500 Date: Sun, 25 Nov 2007 14:56:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: Carlos Eduardo Seo , gdb-patches@sources.redhat.com Subject: Re: [patch] XLF Fortran: Remove an inappropriate complaint [Re: XLF Fortran arrays test] Message-ID: <20071125145555.GB30778@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , Carlos Eduardo Seo , gdb-patches@sources.redhat.com References: <20071116032002.GA9885@host0.dyn.jankratochvil.net> <473DD96D.5020900@linux.vnet.ibm.com> <20071116194448.GA32395@host0.dyn.jankratochvil.net> <4741A077.9050900@linux.vnet.ibm.com> <20071123015957.GA3202@host0.dyn.jankratochvil.net> <20071123021120.GA11797@host0.dyn.jankratochvil.net> <20071123163125.GA23275@host0.dyn.jankratochvil.net> <4747086C.3070100@linux.vnet.ibm.com> <20071123172104.GA23776@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071123172104.GA23776@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00465.txt.bz2 On Fri, Nov 23, 2007 at 06:21:04PM +0100, Jan Kratochvil wrote: > On Fri, 23 Nov 2007 18:05:48 +0100, Carlos Eduardo Seo wrote: > ... > > The only strange behavior is that when I set a breakpoint, I get this > > message: > > > > During symbol reading, DW_AT_type missing from DW_TAG_subrange_type. > > This code was there already before my changes. And the XLF output really > misses DW_AT_type for DW_TAG_subrange_type. But it should be correct: > http://dwarf.freestandards.org/Dwarf3.pdf > 5.12 Subrange Type Entries > The subrange entry may have a DW_AT_type attribute to describe the type > of object, called the basis type, of whose values this subrange is > a subset. > > "may have" should not produce a `complaint' category message as it is not > a standard violation. > > Providing a patch but I do not know much more about it. Here's the rest of what the standard has to say: == If the subrange entry has no type attribute describing the basis type, the basis type is assumed to be the same as the object described by the lower bound attribute (if it references an object). If there is no lower bound attribute, or that attribute does not reference an object, the basis type is the type of the upper bound or count attribute (if either of them references an object). If there is no upper bound or count attribute, or neither references an object, the type is assumed to be the same type, in the source language of the compilation unit containing the subrange entry, as a signed integer with the same size as an address on the target machine. == It looks to me like (before your other patches?) we do not support the bounds or count referring to objects. The code below the complaint is creating a signed integer type the size of an address. So your patch is OK. Thanks. -- Daniel Jacobowitz CodeSourcery