[patch] XLF Fortran: Remove an inappropriate complaint [Re: XLF Fortran arrays test]

[Jan Kratochvil <jan.kratochvil@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

On Fri, 23 Nov 2007 18:05:48 +0100, Carlos Eduardo Seo wrote:
...
> The only strange behavior is that when I set a breakpoint, I get this
> message:
> 
> During symbol reading, DW_AT_type missing from DW_TAG_subrange_type.

This code was there already before my changes.  And the XLF output really
misses DW_AT_type for DW_TAG_subrange_type.  But it should be correct:
	http://dwarf.freestandards.org/Dwarf3.pdf
	5.12 Subrange Type Entries
	The subrange entry may have a DW_AT_type attribute to describe the type
	of object, called the basis type, of whose values this subrange is
	a subset.

"may have" should not produce a `complaint' category message as it is not
a standard violation.

Providing a patch but I do not know much more about it.


Regards,
Jan

[-- Attachment #2: gdb-subrange-no-type-ok.patch --]
[-- Type: text/plain, Size: 611 bytes --]

2007-11-23  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* dwarf2read.c (read_subrange_type): Remove the missing DW_AT_type
	complaint.
	
--- ./gdb/dwarf2read.c	25 Oct 2007 20:54:27 -0000	1.236
+++ ./gdb/dwarf2read.c	23 Nov 2007 17:17:44 -0000
@@ -4933,8 +4933,6 @@ read_subrange_type (struct die_info *die
   base_type = die_type (die, cu);
   if (TYPE_CODE (base_type) == TYPE_CODE_VOID)
     {
-      complaint (&symfile_complaints,
-                _("DW_AT_type missing from DW_TAG_subrange_type"));
       base_type
 	= dwarf_base_type (DW_ATE_signed,
 			   gdbarch_addr_bit (current_gdbarch) / 8, cu);