Fix for convert_register_p patch

Fix for convert_register_p patch

[Markus Deuling]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi,

I posted a version of the patch which was missing a small part. The current convert_register_p patch 
currently breaks some targets. This is the fix.

Ok to commit? Are this kind of things obvious patches ?

ChangeLog:

	* arch-utils.c (generic_convert_register_p): Add gdbarch as parameter.
	* arch-utils.h (generic_convert_register_p): Likewise.

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff-fix --]
[-- Type: text/plain, Size: 1076 bytes --]

diff -urpN src/gdb/arch-utils.c dev2/gdb/arch-utils.c
--- src/gdb/arch-utils.c	2007-11-07 07:58:31.000000000 +0100
+++ dev2/gdb/arch-utils.c	2007-11-09 09:17:59.000000000 +0100
@@ -162,7 +162,8 @@ legacy_virtual_frame_pointer (struct gdb
 
 \f
 int
-generic_convert_register_p (int regnum, struct type *type)
+generic_convert_register_p (struct gdbarch *gdbarch, int regnum,
+			    struct type *type)
 {
   return 0;
 }
diff -urpN src/gdb/arch-utils.h dev2/gdb/arch-utils.h
--- src/gdb/arch-utils.h	2007-10-13 02:06:52.000000000 +0200
+++ dev2/gdb/arch-utils.h	2007-11-09 09:18:19.000000000 +0100
@@ -73,7 +73,8 @@ extern int generic_in_solib_return_tramp
 extern int generic_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc);
 
 /* By default, registers are not convertible.  */
-extern int generic_convert_register_p (int regnum, struct type *type);
+extern int generic_convert_register_p (struct gdbarch *gdbarch, int regnum,
+				       struct type *type);
 
 extern int default_stabs_argument_has_addr (struct gdbarch *gdbarch,
 					    struct type *type);

Re: Fix for convert_register_p patch

[Ulrich Weigand]

Markus Deuling wrote:

> I posted a version of the patch which was missing a small part.
> The current convert_register_p patch currently breaks some targets.
> This is the fix.

Oops, sorry for missing that.

> Ok to commit? Are this kind of things obvious patches ?

I'd have considered a fix like this obvious.

> 	* arch-utils.c (generic_convert_register_p): Add gdbarch as parameter.
> 	* arch-utils.h (generic_convert_register_p): Likewise.

I've checked this in now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com