Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: GDB Patches <gdb-patches@sourceware.org>,
	        Ulrich Weigand <uweigand@de.ibm.com>,
	        Daniel Jacobowitz <drow@false.org>,
	        Maxim Grigoriev <maxim@tensilica.com>
Subject: Fix for convert_register_p patch
Date: Fri, 09 Nov 2007 08:27:00 -0000	[thread overview]
Message-ID: <4734198B.80304@de.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi,

I posted a version of the patch which was missing a small part. The current convert_register_p patch 
currently breaks some targets. This is the fix.

Ok to commit? Are this kind of things obvious patches ?

ChangeLog:

	* arch-utils.c (generic_convert_register_p): Add gdbarch as parameter.
	* arch-utils.h (generic_convert_register_p): Likewise.

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff-fix --]
[-- Type: text/plain, Size: 1076 bytes --]

diff -urpN src/gdb/arch-utils.c dev2/gdb/arch-utils.c
--- src/gdb/arch-utils.c	2007-11-07 07:58:31.000000000 +0100
+++ dev2/gdb/arch-utils.c	2007-11-09 09:17:59.000000000 +0100
@@ -162,7 +162,8 @@ legacy_virtual_frame_pointer (struct gdb
 
 \f
 int
-generic_convert_register_p (int regnum, struct type *type)
+generic_convert_register_p (struct gdbarch *gdbarch, int regnum,
+			    struct type *type)
 {
   return 0;
 }
diff -urpN src/gdb/arch-utils.h dev2/gdb/arch-utils.h
--- src/gdb/arch-utils.h	2007-10-13 02:06:52.000000000 +0200
+++ dev2/gdb/arch-utils.h	2007-11-09 09:18:19.000000000 +0100
@@ -73,7 +73,8 @@ extern int generic_in_solib_return_tramp
 extern int generic_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc);
 
 /* By default, registers are not convertible.  */
-extern int generic_convert_register_p (int regnum, struct type *type);
+extern int generic_convert_register_p (struct gdbarch *gdbarch, int regnum,
+				       struct type *type);
 
 extern int default_stabs_argument_has_addr (struct gdbarch *gdbarch,
 					    struct type *type);

             reply	other threads:[~2007-11-09  8:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09  8:27 Markus Deuling [this message]
2007-11-09 13:12 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4734198B.80304@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=maxim@tensilica.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox