From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18625 invoked by alias); 9 Nov 2007 13:12:47 -0000 Received: (qmail 18616 invoked by uid 22791); 9 Nov 2007 13:12:47 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Nov 2007 13:12:44 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id lA9DCeZF301882 for ; Fri, 9 Nov 2007 13:12:40 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lA9DCeME1356008 for ; Fri, 9 Nov 2007 14:12:40 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA9DCdlx021795 for ; Fri, 9 Nov 2007 14:12:40 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lA9DCdA3021783; Fri, 9 Nov 2007 14:12:39 +0100 Message-Id: <200711091312.lA9DCdA3021783@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 9 Nov 2007 14:12:39 +0100 Subject: Re: Fix for convert_register_p patch To: deuling@de.ibm.com (Markus Deuling) Date: Fri, 09 Nov 2007 13:12:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), drow@false.org (Daniel Jacobowitz), maxim@tensilica.com (Maxim Grigoriev) In-Reply-To: <4734198B.80304@de.ibm.com> from "Markus Deuling" at Nov 09, 2007 09:25:47 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00196.txt.bz2 Markus Deuling wrote: > I posted a version of the patch which was missing a small part. > The current convert_register_p patch currently breaks some targets. > This is the fix. Oops, sorry for missing that. > Ok to commit? Are this kind of things obvious patches ? I'd have considered a fix like this obvious. > * arch-utils.c (generic_convert_register_p): Add gdbarch as parameter. > * arch-utils.h (generic_convert_register_p): Likewise. I've checked this in now. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com