[RFC] Remove CHILD_POST_STARTUP_INFERIOR

[RFC] Remove CHILD_POST_STARTUP_INFERIOR

[Pierre Muller]

CHILD_POST_STARTUP_INFERIOR
is currently only set in 
config/i386/nm-i386.h
and used nowhere inside gdb source tree
(tested with "grep CHILD_POST_STARTUP_INFERIOR * */* */*/* */*/*/*"
that returns only ChangeLog entries and the file above).

Thus this is quite an obvious patch.
Nevertheless, I had a question related to this:
- is it possible to change the category
in ARI so that if it reappears it becomes a
regression?

Would the following change in gdb_ari.sh
be the right change for this?

Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.73
diff -u -p -r1.73 gdb_ari.sh
--- gdb_ari.sh  14 Aug 2005 22:47:46 -0000      1.73
+++ gdb_ari.sh  5 Oct 2007 09:35:25 -0000
@@ -632,7 +632,7 @@ Replace CHILD_PREPARE_TO_STORE with inf-

 BEGIN { doc["CHILD_POST_STARTUP_INFERIOR"] = "\
 Replace CHILD_POST_STARTUP_INFERIOR with inf-child.c"
-    category["CHILD_POST_STARTUP_INFERIOR"] = ari_obsolete
+    category["CHILD_POST_STARTUP_INFERIOR"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_POST_STARTUP_INFERIOR([^_[:alnum:]]|$)/ {
     fail("CHILD_POST_STARTUP_INFERIOR")


Pierre Muller

ChangeLog entry:

2007-10-04  Pierre Muller  <muller@ics.u-strasbg.fr>

        * config/i386/nm-i386.h (CHILD_POST_STARTUP_INFERIOR): ARI fix:
Remove.


Index: config/i386/nm-i386.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nm-i386.h,v
retrieving revision 1.10
diff -u -p -r1.10 nm-i386.h
--- config/i386/nm-i386.h       23 Aug 2007 18:08:48 -0000      1.10
+++ config/i386/nm-i386.h       5 Oct 2007 09:28:10 -0000
@@ -110,10 +110,6 @@ extern int i386_stopped_by_watchpoint (v
 #define target_remove_hw_breakpoint(bp_tgt) \
   i386_remove_hw_breakpoint (bp_tgt)

-/* child_post_startup_inferior used to
-   reset all debug registers by calling i386_cleanup_dregs ().  */
-#define CHILD_POST_STARTUP_INFERIOR
-
 #endif /* I386_USE_GENERIC_WATCHPOINTS */

 #endif /* NM_I386_H */

Re: [RFC] Remove CHILD_POST_STARTUP_INFERIOR

[Daniel Jacobowitz]

On Fri, Oct 05, 2007 at 11:42:35AM +0200, Pierre Muller wrote:
> CHILD_POST_STARTUP_INFERIOR
> is currently only set in 
> config/i386/nm-i386.h
> and used nowhere inside gdb source tree
> (tested with "grep CHILD_POST_STARTUP_INFERIOR * */* */*/* */*/*/*"
> that returns only ChangeLog entries and the file above).

This is fine, thanks.

> Would the following change in gdb_ari.sh
> be the right change for this?

No one is going to know the answer to this; there's no one left on the
GDB lists who knows anything about the ARI scripts.  If you think it's
right, I can check it in for you.

-- 
Daniel Jacobowitz
CodeSourcery

RE: [RFC] Remove CHILD_POST_STARTUP_INFERIOR

[Pierre Muller]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
> Sent: Friday, October 05, 2007 3:15 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFC] Remove CHILD_POST_STARTUP_INFERIOR
> 
> On Fri, Oct 05, 2007 at 11:42:35AM +0200, Pierre Muller wrote:
> > CHILD_POST_STARTUP_INFERIOR
> > is currently only set in
> > config/i386/nm-i386.h
> > and used nowhere inside gdb source tree
> > (tested with "grep CHILD_POST_STARTUP_INFERIOR * */* */*/* */*/*/*"
> > that returns only ChangeLog entries and the file above).
> 
> This is fine, thanks.

Thanks, committed.

Pierre Muller

RE: [RFC] Remove CHILD_POST_STARTUP_INFERIOR

[Pierre Muller]

  Daniel,
could you please commit this change to gdb_ari.sh
into the ss directory?
 I tested it locally and it seems to work OK.

Thanks in advance,

Pierre Muller

ChangeLog entry (does not exist :()

2007-10-08  Pierre Muller  <muller@ics.u-strasbg.fr>

	* gdb_ari.sh (CHILD_POST_STARTUP_INFERIOR): Mark as fixed,
	by moving to ari_regression category.


Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.73
diff -u -p -r1.73 gdb_ari.sh
--- gdb_ari.sh  14 Aug 2005 22:47:46 -0000      1.73
+++ gdb_ari.sh  8 Oct 2007 11:40:21 -0000
@@ -632,7 +632,7 @@ Replace CHILD_PREPARE_TO_STORE with inf-

 BEGIN { doc["CHILD_POST_STARTUP_INFERIOR"] = "\
 Replace CHILD_POST_STARTUP_INFERIOR with inf-child.c"
-    category["CHILD_POST_STARTUP_INFERIOR"] = ari_obsolete
+    category["CHILD_POST_STARTUP_INFERIOR"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_POST_STARTUP_INFERIOR([^_[:alnum:]]|$)/ {
     fail("CHILD_POST_STARTUP_INFERIOR")



> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
> Sent: Friday, October 05, 2007 3:15 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFC] Remove CHILD_POST_STARTUP_INFERIOR
> 
> On Fri, Oct 05, 2007 at 11:42:35AM +0200, Pierre Muller wrote:
> > CHILD_POST_STARTUP_INFERIOR
> > is currently only set in
> > config/i386/nm-i386.h
> > and used nowhere inside gdb source tree
> > (tested with "grep CHILD_POST_STARTUP_INFERIOR * */* */*/* */*/*/*"
> > that returns only ChangeLog entries and the file above).
> 
> This is fine, thanks.
> 
> > Would the following change in gdb_ari.sh
> > be the right change for this?
> 
> No one is going to know the answer to this; there's no one left on the
> GDB lists who knows anything about the ARI scripts.  If you think it's
> right, I can check it in for you.
> 
> --
> Daniel Jacobowitz
> CodeSourcery

Re: [RFC] Remove CHILD_POST_STARTUP_INFERIOR

['Daniel Jacobowitz']

On Mon, Oct 08, 2007 at 01:56:53PM +0200, Pierre Muller wrote:
>   Daniel,
> could you please commit this change to gdb_ari.sh
> into the ss directory?
>  I tested it locally and it seems to work OK.

Done, thanks.

-- 
Daniel Jacobowitz
CodeSourcery