Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: <gdb-patches@sourceware.org>
Subject: [RFC] Remove CHILD_POST_STARTUP_INFERIOR
Date: Fri, 05 Oct 2007 09:42:00 -0000	[thread overview]
Message-ID: <007301c80734$0f23aff0$2d6b0fd0$@u-strasbg.fr> (raw)

CHILD_POST_STARTUP_INFERIOR
is currently only set in 
config/i386/nm-i386.h
and used nowhere inside gdb source tree
(tested with "grep CHILD_POST_STARTUP_INFERIOR * */* */*/* */*/*/*"
that returns only ChangeLog entries and the file above).

Thus this is quite an obvious patch.
Nevertheless, I had a question related to this:
- is it possible to change the category
in ARI so that if it reappears it becomes a
regression?

Would the following change in gdb_ari.sh
be the right change for this?

Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.73
diff -u -p -r1.73 gdb_ari.sh
--- gdb_ari.sh  14 Aug 2005 22:47:46 -0000      1.73
+++ gdb_ari.sh  5 Oct 2007 09:35:25 -0000
@@ -632,7 +632,7 @@ Replace CHILD_PREPARE_TO_STORE with inf-

 BEGIN { doc["CHILD_POST_STARTUP_INFERIOR"] = "\
 Replace CHILD_POST_STARTUP_INFERIOR with inf-child.c"
-    category["CHILD_POST_STARTUP_INFERIOR"] = ari_obsolete
+    category["CHILD_POST_STARTUP_INFERIOR"] = ari_regression
 }
 /(^|[^_[:alnum:]])CHILD_POST_STARTUP_INFERIOR([^_[:alnum:]]|$)/ {
     fail("CHILD_POST_STARTUP_INFERIOR")


Pierre Muller

ChangeLog entry:

2007-10-04  Pierre Muller  <muller@ics.u-strasbg.fr>

        * config/i386/nm-i386.h (CHILD_POST_STARTUP_INFERIOR): ARI fix:
Remove.


Index: config/i386/nm-i386.h
===================================================================
RCS file: /cvs/src/src/gdb/config/i386/nm-i386.h,v
retrieving revision 1.10
diff -u -p -r1.10 nm-i386.h
--- config/i386/nm-i386.h       23 Aug 2007 18:08:48 -0000      1.10
+++ config/i386/nm-i386.h       5 Oct 2007 09:28:10 -0000
@@ -110,10 +110,6 @@ extern int i386_stopped_by_watchpoint (v
 #define target_remove_hw_breakpoint(bp_tgt) \
   i386_remove_hw_breakpoint (bp_tgt)

-/* child_post_startup_inferior used to
-   reset all debug registers by calling i386_cleanup_dregs ().  */
-#define CHILD_POST_STARTUP_INFERIOR
-
 #endif /* I386_USE_GENERIC_WATCHPOINTS */

 #endif /* NM_I386_H */




             reply	other threads:[~2007-10-05  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-05  9:42 Pierre Muller [this message]
2007-10-05 13:14 ` Daniel Jacobowitz
2007-10-08  7:50   ` Pierre Muller
2007-10-08 11:56   ` Pierre Muller
2007-10-08 12:01     ` 'Daniel Jacobowitz'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007301c80734$0f23aff0$2d6b0fd0$@u-strasbg.fr' \
    --to=muller@ics.u-strasbg.fr \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox