From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18170 invoked by alias); 5 Oct 2007 09:42:35 -0000 Received: (qmail 18161 invoked by uid 22791); 5 Oct 2007 09:42:34 -0000 X-Spam-Check-By: sourceware.org Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Oct 2007 09:42:30 +0000 Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) by ics.u-strasbg.fr (Postfix) with ESMTP id 5294D18701B for ; Fri, 5 Oct 2007 11:47:15 +0200 (CEST) From: "Pierre Muller" To: Subject: [RFC] Remove CHILD_POST_STARTUP_INFERIOR Date: Fri, 05 Oct 2007 09:42:00 -0000 Message-ID: <007301c80734$0f23aff0$2d6b0fd0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00046.txt.bz2 CHILD_POST_STARTUP_INFERIOR is currently only set in config/i386/nm-i386.h and used nowhere inside gdb source tree (tested with "grep CHILD_POST_STARTUP_INFERIOR * */* */*/* */*/*/*" that returns only ChangeLog entries and the file above). Thus this is quite an obvious patch. Nevertheless, I had a question related to this: - is it possible to change the category in ARI so that if it reappears it becomes a regression? Would the following change in gdb_ari.sh be the right change for this? Index: gdb_ari.sh =================================================================== RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v retrieving revision 1.73 diff -u -p -r1.73 gdb_ari.sh --- gdb_ari.sh 14 Aug 2005 22:47:46 -0000 1.73 +++ gdb_ari.sh 5 Oct 2007 09:35:25 -0000 @@ -632,7 +632,7 @@ Replace CHILD_PREPARE_TO_STORE with inf- BEGIN { doc["CHILD_POST_STARTUP_INFERIOR"] = "\ Replace CHILD_POST_STARTUP_INFERIOR with inf-child.c" - category["CHILD_POST_STARTUP_INFERIOR"] = ari_obsolete + category["CHILD_POST_STARTUP_INFERIOR"] = ari_regression } /(^|[^_[:alnum:]])CHILD_POST_STARTUP_INFERIOR([^_[:alnum:]]|$)/ { fail("CHILD_POST_STARTUP_INFERIOR") Pierre Muller ChangeLog entry: 2007-10-04 Pierre Muller * config/i386/nm-i386.h (CHILD_POST_STARTUP_INFERIOR): ARI fix: Remove. Index: config/i386/nm-i386.h =================================================================== RCS file: /cvs/src/src/gdb/config/i386/nm-i386.h,v retrieving revision 1.10 diff -u -p -r1.10 nm-i386.h --- config/i386/nm-i386.h 23 Aug 2007 18:08:48 -0000 1.10 +++ config/i386/nm-i386.h 5 Oct 2007 09:28:10 -0000 @@ -110,10 +110,6 @@ extern int i386_stopped_by_watchpoint (v #define target_remove_hw_breakpoint(bp_tgt) \ i386_remove_hw_breakpoint (bp_tgt) -/* child_post_startup_inferior used to - reset all debug registers by calling i386_cleanup_dregs (). */ -#define CHILD_POST_STARTUP_INFERIOR - #endif /* I386_USE_GENERIC_WATCHPOINTS */ #endif /* NM_I386_H */