From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>,
Ulrich Weigand <uweigand@de.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: For example only, updated Windows DLL support and gdbserver DLL support
Date: Mon, 18 Jun 2007 21:12:00 -0000 [thread overview]
Message-ID: <20070618211213.GA1110@caradoc.them.org> (raw)
In-Reply-To: <20070618210728.GB1813@ednor>
On Mon, Jun 18, 2007 at 05:07:28PM -0400, Christopher Faylor wrote:
> I have no objections to this with two exceptions:
>
> - You use #ifdef __CYGWIN__ . That would be the only place in the file
> where that is used. I don't see any reason for this unless your patch
> is also going to allow native Windows support. If that is the case,
> then maybe that part should be provided separately.
>
> - You seemed to have gratuitously pulled out the code which deals with
> cygwin exceptions into a separate function. I don't think this has
> anything to do with solibs and probably shouldn't be part of any
> final patch.
Pedro, what do you remember about these? At least, I don't _think_ it
was me...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-06-18 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 15:08 Daniel Jacobowitz
2007-06-18 21:07 ` Christopher Faylor
2007-06-18 21:12 ` Daniel Jacobowitz [this message]
2007-06-18 21:54 ` Pedro Alves
2007-06-18 23:28 ` Christopher Faylor
2007-06-19 19:06 ` Ulrich Weigand
2007-06-19 19:19 ` Daniel Jacobowitz
2007-06-19 20:00 ` Ulrich Weigand
2007-06-19 20:12 ` Daniel Jacobowitz
2007-06-19 22:43 ` Pedro Alves
2007-06-19 23:34 ` Daniel Jacobowitz
2007-06-19 23:58 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070618211213.GA1110@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox