From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32059 invoked by alias); 18 Jun 2007 21:12:04 -0000 Received: (qmail 32050 invoked by uid 22791); 18 Jun 2007 21:12:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 18 Jun 2007 21:12:01 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id C4AC0982E4; Mon, 18 Jun 2007 21:11:58 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9F6A3982E3; Mon, 18 Jun 2007 21:11:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1I0OWD-0000JF-VT; Mon, 18 Jun 2007 17:12:13 -0400 Date: Mon, 18 Jun 2007 21:12:00 -0000 From: Daniel Jacobowitz To: Pedro Alves , Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: For example only, updated Windows DLL support and gdbserver DLL support Message-ID: <20070618211213.GA1110@caradoc.them.org> Mail-Followup-To: Pedro Alves , Ulrich Weigand , gdb-patches@sourceware.org References: <20070618150816.GA24037@caradoc.them.org> <20070618210728.GB1813@ednor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070618210728.GB1813@ednor> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00352.txt.bz2 On Mon, Jun 18, 2007 at 05:07:28PM -0400, Christopher Faylor wrote: > I have no objections to this with two exceptions: > > - You use #ifdef __CYGWIN__ . That would be the only place in the file > where that is used. I don't see any reason for this unless your patch > is also going to allow native Windows support. If that is the case, > then maybe that part should be provided separately. > > - You seemed to have gratuitously pulled out the code which deals with > cygwin exceptions into a separate function. I don't think this has > anything to do with solibs and probably shouldn't be part of any > final patch. Pedro, what do you remember about these? At least, I don't _think_ it was me... -- Daniel Jacobowitz CodeSourcery