[PATCH]: Add reply to qC packet to gdbserver

[PATCH]: Add reply to qC packet to gdbserver

[Markus Deuling]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi,

this is the reworked patch (see: http://sourceware.org/ml/gdb-patches/2007-05/msg00247.html) for adding replies to qC packets to gdbserver.

Test suite showed no regressions on x86. Is this ok to commit?


ChangeLog:
	* gdbserver/server.c (handle_query): Add reply for qC packet.

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff_gdbserver_qC --]
[-- Type: text/plain, Size: 577 bytes --]

diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c
--- src/gdb/gdbserver/server.c	2007-03-29 05:37:17.000000000 +0200
+++ dev/gdb/gdbserver/server.c	2007-04-27 12:31:45.000000000 +0200
@@ -259,6 +259,14 @@
 {
   static struct inferior_list_entry *thread_ptr;
 
+  /* Reply the current thread id.  */
+  if (strcmp ("qC", own_buf) == 0)
+    {
+      sprintf (own_buf, "QC%lx",
+        ((struct inferior_list_entry *) current_inferior)->id);
+      return;
+    }
+
   if (strcmp ("qSymbol::", own_buf) == 0)
     {
       if (the_target->look_up_symbols != NULL)

Re: [PATCH]: Add reply to qC packet to gdbserver

[Daniel Jacobowitz]

On Tue, May 15, 2007 at 06:00:42AM +0200, Markus Deuling wrote:
> Hi,
> 
> this is the reworked patch (see: 
> http://sourceware.org/ml/gdb-patches/2007-05/msg00247.html) for adding replies 
> to qC packets to gdbserver.
> 
> Test suite showed no regressions on x86. Is this ok to commit?

It should use thread_to_gdb_id, just like qfThreadInfo.  Otherwise OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH]: Add reply to qC packet to gdbserver

[Markus Deuling]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Daniel Jacobowitz wrote:
> On Tue, May 15, 2007 at 06:00:42AM +0200, Markus Deuling wrote:
>> Hi,
>>
>> this is the reworked patch (see: 
>> http://sourceware.org/ml/gdb-patches/2007-05/msg00247.html) for adding replies 
>> to qC packets to gdbserver.
>>
>> Test suite showed no regressions on x86. Is this ok to commit?
> 
> It should use thread_to_gdb_id, just like qfThreadInfo.  Otherwise OK.
> 

Thanks again. I guess this is the patch then :-) Testsuite showed no regressions.

Ok to commit?


ChangeLog:
    * gdbserver/server.c (handle_query): Add reply for qC packet. 


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff_gdbserver_qC --]
[-- Type: text/plain, Size: 605 bytes --]

diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c
--- src/gdb/gdbserver/server.c	2007-05-11 14:04:57.000000000 +0200
+++ dev/gdb/gdbserver/server.c	2007-05-15 19:23:15.000000000 +0200
@@ -259,6 +259,15 @@
 {
   static struct inferior_list_entry *thread_ptr;
 
+  /* Reply the current thread id.  */
+  if (strcmp ("qC", own_buf) == 0)
+    {
+      thread_ptr = all_threads.head;
+      sprintf (own_buf, "QC%x",
+	thread_to_gdb_id ((struct thread_info *)thread_ptr));
+      return;
+    }
+
   if (strcmp ("qSymbol::", own_buf) == 0)
     {
       if (the_target->look_up_symbols != NULL)

Re: [PATCH]: Add reply to qC packet to gdbserver

[Daniel Jacobowitz]

On Tue, May 15, 2007 at 07:41:19PM +0200, Markus Deuling wrote:
> Daniel Jacobowitz wrote:
> > On Tue, May 15, 2007 at 06:00:42AM +0200, Markus Deuling wrote:
> >> Hi,
> >>
> >> this is the reworked patch (see: 
> >> http://sourceware.org/ml/gdb-patches/2007-05/msg00247.html) for adding 
> >> replies to qC packets to gdbserver.
> >>
> >> Test suite showed no regressions on x86. Is this ok to commit?
> > It should use thread_to_gdb_id, just like qfThreadInfo.  Otherwise OK.
> 
> Thanks again. I guess this is the patch then :-) Testsuite showed no 
> regressions.
> 
> Ok to commit?
> 
> 
> ChangeLog:
>    * gdbserver/server.c (handle_query): Add reply for qC packet. 

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH]: Add reply to qC packet to gdbserver

[Ulrich Weigand]

Markus Deuling wrote:

>     * gdbserver/server.c (handle_query): Add reply for qC packet. 

I've committed this now.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com