From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9957 invoked by alias); 15 May 2007 17:42:50 -0000 Received: (qmail 9938 invoked by uid 22791); 15 May 2007 17:42:48 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 May 2007 17:42:44 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l4FHgcwA309832 for ; Tue, 15 May 2007 17:42:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4FHgc3e3309814 for ; Tue, 15 May 2007 19:42:38 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4FHgcRd028119 for ; Tue, 15 May 2007 19:42:38 +0200 Received: from [9.145.149.102] (sig-9-145-149-102.de.ibm.com [9.145.149.102]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l4FHgZ2p028060 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 May 2007 19:42:37 +0200 Message-ID: <4649F0BF.9000507@de.ibm.com> Date: Tue, 15 May 2007 17:42:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Daniel Jacobowitz , GDB Patches CC: Ulrich Weigand Subject: Re: [PATCH]: Add reply to qC packet to gdbserver References: <4649306A.6090404@de.ibm.com> <20070515104946.GA26259@caradoc.them.org> In-Reply-To: <20070515104946.GA26259@caradoc.them.org> Content-Type: multipart/mixed; boundary="------------080202010806030108080805" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00265.txt.bz2 This is a multi-part message in MIME format. --------------080202010806030108080805 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 654 Daniel Jacobowitz wrote: > On Tue, May 15, 2007 at 06:00:42AM +0200, Markus Deuling wrote: >> Hi, >> >> this is the reworked patch (see: >> http://sourceware.org/ml/gdb-patches/2007-05/msg00247.html) for adding replies >> to qC packets to gdbserver. >> >> Test suite showed no regressions on x86. Is this ok to commit? > > It should use thread_to_gdb_id, just like qfThreadInfo. Otherwise OK. > Thanks again. I guess this is the patch then :-) Testsuite showed no regressions. Ok to commit? ChangeLog: * gdbserver/server.c (handle_query): Add reply for qC packet. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------080202010806030108080805 Content-Type: text/plain; name="diff_gdbserver_qC" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff_gdbserver_qC" Content-length: 605 diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c --- src/gdb/gdbserver/server.c 2007-05-11 14:04:57.000000000 +0200 +++ dev/gdb/gdbserver/server.c 2007-05-15 19:23:15.000000000 +0200 @@ -259,6 +259,15 @@ { static struct inferior_list_entry *thread_ptr; + /* Reply the current thread id. */ + if (strcmp ("qC", own_buf) == 0) + { + thread_ptr = all_threads.head; + sprintf (own_buf, "QC%x", + thread_to_gdb_id ((struct thread_info *)thread_ptr)); + return; + } + if (strcmp ("qSymbol::", own_buf) == 0) { if (the_target->look_up_symbols != NULL) --------------080202010806030108080805--