Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Markus Deuling <deuling@de.ibm.com>
To: Daniel Jacobowitz <drow@false.org>,
	        GDB Patches <gdb-patches@sourceware.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [PATCH]: Add reply to qC packet to gdbserver
Date: Tue, 15 May 2007 17:42:00 -0000	[thread overview]
Message-ID: <4649F0BF.9000507@de.ibm.com> (raw)
In-Reply-To: <20070515104946.GA26259@caradoc.them.org>

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

Daniel Jacobowitz wrote:
> On Tue, May 15, 2007 at 06:00:42AM +0200, Markus Deuling wrote:
>> Hi,
>>
>> this is the reworked patch (see: 
>> http://sourceware.org/ml/gdb-patches/2007-05/msg00247.html) for adding replies 
>> to qC packets to gdbserver.
>>
>> Test suite showed no regressions on x86. Is this ok to commit?
> 
> It should use thread_to_gdb_id, just like qfThreadInfo.  Otherwise OK.
> 

Thanks again. I guess this is the patch then :-) Testsuite showed no regressions.

Ok to commit?


ChangeLog:
    * gdbserver/server.c (handle_query): Add reply for qC packet. 


-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com


[-- Attachment #2: diff_gdbserver_qC --]
[-- Type: text/plain, Size: 605 bytes --]

diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c
--- src/gdb/gdbserver/server.c	2007-05-11 14:04:57.000000000 +0200
+++ dev/gdb/gdbserver/server.c	2007-05-15 19:23:15.000000000 +0200
@@ -259,6 +259,15 @@
 {
   static struct inferior_list_entry *thread_ptr;
 
+  /* Reply the current thread id.  */
+  if (strcmp ("qC", own_buf) == 0)
+    {
+      thread_ptr = all_threads.head;
+      sprintf (own_buf, "QC%x",
+	thread_to_gdb_id ((struct thread_info *)thread_ptr));
+      return;
+    }
+
   if (strcmp ("qSymbol::", own_buf) == 0)
     {
       if (the_target->look_up_symbols != NULL)

  reply	other threads:[~2007-05-15 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15  4:02 Markus Deuling
2007-05-15 10:49 ` Daniel Jacobowitz
2007-05-15 17:42   ` Markus Deuling [this message]
2007-05-15 18:34     ` Daniel Jacobowitz
2007-05-16 15:27     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4649F0BF.9000507@de.ibm.com \
    --to=deuling@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox