From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sourceware.org
Subject: Re: -var-create testsuite updates [PATCH]
Date: Tue, 27 Feb 2007 17:10:00 -0000 [thread overview]
Message-ID: <20070227171030.GH31729@caradoc.them.org> (raw)
In-Reply-To: <17876.51347.325984.284231@kahikatea.snap.net.nz>
On Fri, Feb 16, 2007 at 09:54:43AM +1300, Nick Roberts wrote:
> > > > The old tests were deliberately checking that the varobj was created
> > > > with the correct type, and the new ones aren't :-(
> > >
> > > (Groan) I picked up the tests which were designed to fail but changed the
> > > others by autopilot. I'll work my way through the changes to work out how
> > > many others we should have kept and submit a new patch.
>
> I've reverted the tests now to use mi_gdb_test and included value field in
> output. I get the same test results. Where possible, I've used a specific
> value in the value field of miN-var-cmd.exp and miN-var-child.exp to try to
> pick up any problems with that field. In the other files I've just used a
> wildcard.
Thanks a lot for doing this, Nick. The patch is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-27 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 16:20 -var-create testsuite updates Daniel Jacobowitz
2007-02-09 20:48 ` Nick Roberts
2007-02-09 20:57 ` Daniel Jacobowitz
2007-02-11 21:43 ` Nick Roberts
2007-02-11 21:46 ` Daniel Jacobowitz
2007-02-12 6:18 ` Vladimir Prus
2007-02-12 9:30 ` Nick Roberts
2007-02-13 12:03 ` Daniel Jacobowitz
2007-02-15 20:55 ` -var-create testsuite updates [PATCH] Nick Roberts
2007-02-27 17:10 ` Daniel Jacobowitz [this message]
2007-03-09 1:00 ` Ulrich Weigand
2007-03-09 1:41 ` Nick Roberts
2007-03-09 2:22 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070227171030.GH31729@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox