Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sourceware.org
Subject: Re: -var-create testsuite updates
Date: Fri, 09 Feb 2007 20:57:00 -0000	[thread overview]
Message-ID: <20070209205749.GA2730@nevyn.them.org> (raw)
In-Reply-To: <17868.56856.625440.923769@kahikatea.snap.net.nz>

On Sat, Feb 10, 2007 at 09:48:24AM +1300, Nick Roberts wrote:
>  > I noticed this today, which I should have thought of earlier:
>  > 
>  > -mi_gdb_test "-var-create func * func" \
>  > -       "\\^done,name=\"func\",numchild=\"0\",type=\"void \\(\\*\\)\\((void|)\\)\"" \
>  > -       "create local variable func"
>  > +mi_create_varobj func func "create local variable func"
>  > 
>  > The old tests were deliberately checking that the varobj was created with
>  > the correct type, and the new ones aren't :-(
> 
> (Groan) I picked up the tests which were designed to fail but changed the
> others by autopilot.  I'll work my way through the changes to work out how many
> others we should have kept and submit a new patch.

Thanks a lot!  I didn't want to actually ask you to do this, since it's
a pile of grunt work, but it would certainly be nice to have them back.

I only noticed because I had a few patches which changed long to
long( int)? to support another compiler, and they no longer applied.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-02-09 20:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 16:20 Daniel Jacobowitz
2007-02-09 20:48 ` Nick Roberts
2007-02-09 20:57   ` Daniel Jacobowitz [this message]
2007-02-11 21:43     ` Nick Roberts
2007-02-11 21:46       ` Daniel Jacobowitz
2007-02-12  6:18       ` Vladimir Prus
2007-02-12  9:30         ` Nick Roberts
2007-02-13 12:03           ` Daniel Jacobowitz
2007-02-15 20:55     ` -var-create testsuite updates [PATCH] Nick Roberts
2007-02-27 17:10       ` Daniel Jacobowitz
2007-03-09  1:00       ` Ulrich Weigand
2007-03-09  1:41         ` Nick Roberts
2007-03-09  2:22           ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070209205749.GA2730@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox