Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: -var-create testsuite updates
Date: Sun, 11 Feb 2007 21:43:00 -0000	[thread overview]
Message-ID: <17871.36317.301688.678052@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20070209205749.GA2730@nevyn.them.org>

 > > (Groan) I picked up the tests which were designed to fail but changed the
 > > others by autopilot.  I'll work my way through the changes to work out how many
 > > others we should have kept and submit a new patch.
 > 
 > Thanks a lot!  I didn't want to actually ask you to do this, since it's
 > a pile of grunt work, but it would certainly be nice to have them back.
 > 
 > I only noticed because I had a few patches which changed long to
 > long( int)? to support another compiler, and they no longer applied.

Some tests are explicitly testing -var-create e.g mi-var-cmd.exp, others
might not be but still provide a handy check on the output e.g

*** gdb.mi/mi-var-child.exp
  
  # Test: c_variable-4.2
  # Desc: create variable "struct_declarations"
  mi_gdb_test "-var-create struct_declarations * struct_declarations" \
  	"\\^done,name=\"struct_declarations\",numchild=\"11\",type=\"struct _struct_decl\"" \
 	"create local variable struct_declarations"

I don't really like mi_create_varobj as it removes checks on type, number of
children etc.  How about if I revert all my changes which use mi_create_varobj
and just add value=\".*\" to the regexp in each mi_gdb_test for -var-create?

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2007-02-11 21:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 16:20 Daniel Jacobowitz
2007-02-09 20:48 ` Nick Roberts
2007-02-09 20:57   ` Daniel Jacobowitz
2007-02-11 21:43     ` Nick Roberts [this message]
2007-02-11 21:46       ` Daniel Jacobowitz
2007-02-12  6:18       ` Vladimir Prus
2007-02-12  9:30         ` Nick Roberts
2007-02-13 12:03           ` Daniel Jacobowitz
2007-02-15 20:55     ` -var-create testsuite updates [PATCH] Nick Roberts
2007-02-27 17:10       ` Daniel Jacobowitz
2007-03-09  1:00       ` Ulrich Weigand
2007-03-09  1:41         ` Nick Roberts
2007-03-09  2:22           ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17871.36317.301688.678052@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox