From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27872 invoked by alias); 11 Feb 2007 21:43:04 -0000 Received: (qmail 27862 invoked by uid 22791); 11 Feb 2007 21:43:03 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 11 Feb 2007 21:42:58 +0000 Received: from kahikatea.snap.net.nz (121.61.255.123.dynamic.snap.net.nz [123.255.61.121]) by viper.snap.net.nz (Postfix) with ESMTP id F22443D95EA; Mon, 12 Feb 2007 10:42:54 +1300 (NZDT) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id C3C304F702; Mon, 12 Feb 2007 10:42:54 +1300 (NZDT) From: Nick Roberts MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17871.36317.301688.678052@kahikatea.snap.net.nz> Date: Sun, 11 Feb 2007 21:43:00 -0000 To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: -var-create testsuite updates In-Reply-To: <20070209205749.GA2730@nevyn.them.org> References: <20070209162019.GA14230@nevyn.them.org> <17868.56856.625440.923769@kahikatea.snap.net.nz> <20070209205749.GA2730@nevyn.them.org> X-Mailer: VM 7.19 under Emacs 22.0.93.10 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00158.txt.bz2 > > (Groan) I picked up the tests which were designed to fail but changed the > > others by autopilot. I'll work my way through the changes to work out how many > > others we should have kept and submit a new patch. > > Thanks a lot! I didn't want to actually ask you to do this, since it's > a pile of grunt work, but it would certainly be nice to have them back. > > I only noticed because I had a few patches which changed long to > long( int)? to support another compiler, and they no longer applied. Some tests are explicitly testing -var-create e.g mi-var-cmd.exp, others might not be but still provide a handy check on the output e.g *** gdb.mi/mi-var-child.exp # Test: c_variable-4.2 # Desc: create variable "struct_declarations" mi_gdb_test "-var-create struct_declarations * struct_declarations" \ "\\^done,name=\"struct_declarations\",numchild=\"11\",type=\"struct _struct_decl\"" \ "create local variable struct_declarations" I don't really like mi_create_varobj as it removes checks on type, number of children etc. How about if I revert all my changes which use mi_create_varobj and just add value=\".*\" to the regexp in each mi_gdb_test for -var-create? -- Nick http://www.inet.net.nz/~nickrob