From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29636 invoked by alias); 27 Feb 2007 17:10:39 -0000 Received: (qmail 29625 invoked by uid 22791); 27 Feb 2007 17:10:38 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 27 Feb 2007 17:10:32 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HM5qQ-0007uM-O7; Tue, 27 Feb 2007 12:10:30 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HM5qQ-0000Fe-Hh; Tue, 27 Feb 2007 12:10:30 -0500 Date: Tue, 27 Feb 2007 17:10:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sourceware.org Subject: Re: -var-create testsuite updates [PATCH] Message-ID: <20070227171030.GH31729@caradoc.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sourceware.org References: <20070209162019.GA14230@nevyn.them.org> <17868.56856.625440.923769@kahikatea.snap.net.nz> <20070209205749.GA2730@nevyn.them.org> <17876.51347.325984.284231@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17876.51347.325984.284231@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00337.txt.bz2 On Fri, Feb 16, 2007 at 09:54:43AM +1300, Nick Roberts wrote: > > > > The old tests were deliberately checking that the varobj was created > > > > with the correct type, and the new ones aren't :-( > > > > > > (Groan) I picked up the tests which were designed to fail but changed the > > > others by autopilot. I'll work my way through the changes to work out how > > > many others we should have kept and submit a new patch. > > I've reverted the tests now to use mi_gdb_test and included value field in > output. I get the same test results. Where possible, I've used a specific > value in the value field of miN-var-cmd.exp and miN-var-child.exp to try to > pick up any problems with that field. In the other files I've just used a > wildcard. Thanks a lot for doing this, Nick. The patch is OK. -- Daniel Jacobowitz CodeSourcery