[RFA] Fix build failure with old versions of expat

[RFA] Fix build failure with old versions of expat

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

Hello,

On certain machines we have, GDB fails to build because the libexpat
version it has installed is so old that the XMLCALL macro is not
defined (we have version 1.95.8). The attached patch should fix
the problem.

2007-02-20  Joel Brobecker  <brobecker@adacore.com>

        * gdb_expat.h (XMLCALL): Define if not already defined.

Tested on 2 different x86-linux machines: One that does have a recent
libexpat, and another that has an older one.

OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: expat.diff --]
[-- Type: text/plain, Size: 490 bytes --]

Index: gdb_expat.h
===================================================================
RCS file: /cvs/src/src/gdb/gdb_expat.h,v
retrieving revision 1.2
diff -u -p -r1.2 gdb_expat.h
--- gdb_expat.h	9 Jan 2007 17:58:50 -0000	1.2
+++ gdb_expat.h	20 Feb 2007 18:44:01 -0000
@@ -31,4 +31,10 @@
 # define XML_STATUS_ERROR 0
 #endif
 
+/* Old versions of expat do not define this macro, so define it
+   as void.  */
+#ifndef XMLCALL
+#define XMLCALL
+#endif
+
 #endif /* !defined(GDB_EXPAT_H) */

Re: [RFA] Fix build failure with old versions of expat

[Daniel Jacobowitz]

On Tue, Feb 20, 2007 at 11:30:09AM -0800, Joel Brobecker wrote:
> Hello,
> 
> On certain machines we have, GDB fails to build because the libexpat
> version it has installed is so old that the XMLCALL macro is not
> defined (we have version 1.95.8). The attached patch should fix
> the problem.
> 
> 2007-02-20  Joel Brobecker  <brobecker@adacore.com>
> 
>         * gdb_expat.h (XMLCALL): Define if not already defined.
> 
> Tested on 2 different x86-linux machines: One that does have a recent
> libexpat, and another that has an older one.
> 
> OK to apply?

Yes thanks.  Sorry, I think I was supposed to take care of this for
Denis too...


-- 
Daniel Jacobowitz
CodeSourcery

Re: [RFA] Fix build failure with old versions of expat

[Joel Brobecker]

> > 2007-02-20  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * gdb_expat.h (XMLCALL): Define if not already defined.
> > 
> > Tested on 2 different x86-linux machines: One that does have a recent
> > libexpat, and another that has an older one.
> > 
> > OK to apply?
> 
> Yes thanks.

Thanks! Checked in.

> Sorry, I think I was supposed to take care of this for Denis too...

No worries as far as I am concerned. I have been planning on looking
at this for a while too. We share the code, we share the work :-).

-- 
Joel