From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [RFA] Fix build failure with old versions of expat
Date: Tue, 20 Feb 2007 19:30:00 -0000 [thread overview]
Message-ID: <20070220193009.GO29202@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Hello,
On certain machines we have, GDB fails to build because the libexpat
version it has installed is so old that the XMLCALL macro is not
defined (we have version 1.95.8). The attached patch should fix
the problem.
2007-02-20 Joel Brobecker <brobecker@adacore.com>
* gdb_expat.h (XMLCALL): Define if not already defined.
Tested on 2 different x86-linux machines: One that does have a recent
libexpat, and another that has an older one.
OK to apply?
Thanks,
--
Joel
[-- Attachment #2: expat.diff --]
[-- Type: text/plain, Size: 490 bytes --]
Index: gdb_expat.h
===================================================================
RCS file: /cvs/src/src/gdb/gdb_expat.h,v
retrieving revision 1.2
diff -u -p -r1.2 gdb_expat.h
--- gdb_expat.h 9 Jan 2007 17:58:50 -0000 1.2
+++ gdb_expat.h 20 Feb 2007 18:44:01 -0000
@@ -31,4 +31,10 @@
# define XML_STATUS_ERROR 0
#endif
+/* Old versions of expat do not define this macro, so define it
+ as void. */
+#ifndef XMLCALL
+#define XMLCALL
+#endif
+
#endif /* !defined(GDB_EXPAT_H) */
next reply other threads:[~2007-02-20 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 19:30 Joel Brobecker [this message]
2007-02-20 19:37 ` Daniel Jacobowitz
2007-02-20 19:44 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220193009.GO29202@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox