[commit/testsuite] Remove breakpoint/2080 setup_kfail in i386-prologue.exp

[commit/testsuite] Remove breakpoint/2080 setup_kfail in i386-prologue.exp

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hello,

I noticed some KPASS while running i386-prologue.exp. I looked a bit
deeper, and it looks like the associated setup_kfail should be removed.
They have always been there since the tests were added, but the bug
they test was fixed almost at the same time...

Testcase: http://www.sourceware.org/ml/gdb-patches/2006-02/msg00293.html
Patch:    http://www.sourceware.org/ml/gdb-patches/2006-02/msg00302.html

2006-12-20  Joel Brobecker  <brobecker@adacore.com>

        * gdb.arch/i386-prologue.exp: Remove calls to setup_kfail.
        The associated tests should be PASSing.

Tested on x86-linux. It seems pretty obvious, unless I missed something.
Since it's easy to revert, I'll just apply the obvious rule and commit.

Thanks,
-- 
Joel

[-- Attachment #2: kfail.diff --]
[-- Type: text/plain, Size: 1006 bytes --]

Index: gdb.arch/i386-prologue.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-prologue.exp,v
retrieving revision 1.12
diff -u -p -r1.12 i386-prologue.exp
--- gdb.arch/i386-prologue.exp	10 Aug 2006 05:27:19 -0000	1.12
+++ gdb.arch/i386-prologue.exp	20 Dec 2006 09:33:08 -0000
@@ -104,7 +104,6 @@ gdb_test "continue" \
 	"Breakpoint \[0-9\]*.*stack_align.*" \
 	"continue to stack_align + 7"
 
-setup_kfail *-*-* gdb/2080
 gdb_test "backtrace 10" \
 	"#0\[ \t\]*$hex in stack_align.*\r\n#1\[ \t\]*$hex in main.*" \
 	"first backtrace in stack_align"
@@ -115,12 +114,10 @@ gdb_test "continue" \
 
 skip_breakpoint stack_align
 
-setup_kfail *-*-* gdb/2080
 gdb_test "backtrace 10" \
 	"#0\[ \t\]*$hex in stack_align.*\r\n#1\[ \t\]*$hex in main.*" \
 	"second backtrace in stack_align"
 
-setup_kfail *-*-* gdb/2080
 gdb_test "info frame" \
 	".*Saved registers:.*ecx at.*ebp at.*edi at.*eip at.*" \
 	"saved registers in stack_align"

Re: [commit/testsuite] Remove breakpoint/2080 setup_kfail in i386-prologue.exp

[Daniel Jacobowitz]

On Wed, Dec 20, 2006 at 01:50:25PM +0400, Joel Brobecker wrote:
> Tested on x86-linux. It seems pretty obvious, unless I missed something.
> Since it's easy to revert, I'll just apply the obvious rule and commit.

Thanks, and this is fine.  I've just been running the testsuite on i686
again, for the first time in ages, and noticed these.

-- 
Daniel Jacobowitz
CodeSourcery