Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [commit/testsuite] Remove breakpoint/2080 setup_kfail in i386-prologue.exp
Date: Wed, 20 Dec 2006 09:49:00 -0000	[thread overview]
Message-ID: <20061220095025.GE3640@adacore.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hello,

I noticed some KPASS while running i386-prologue.exp. I looked a bit
deeper, and it looks like the associated setup_kfail should be removed.
They have always been there since the tests were added, but the bug
they test was fixed almost at the same time...

Testcase: http://www.sourceware.org/ml/gdb-patches/2006-02/msg00293.html
Patch:    http://www.sourceware.org/ml/gdb-patches/2006-02/msg00302.html

2006-12-20  Joel Brobecker  <brobecker@adacore.com>

        * gdb.arch/i386-prologue.exp: Remove calls to setup_kfail.
        The associated tests should be PASSing.

Tested on x86-linux. It seems pretty obvious, unless I missed something.
Since it's easy to revert, I'll just apply the obvious rule and commit.

Thanks,
-- 
Joel

[-- Attachment #2: kfail.diff --]
[-- Type: text/plain, Size: 1006 bytes --]

Index: gdb.arch/i386-prologue.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-prologue.exp,v
retrieving revision 1.12
diff -u -p -r1.12 i386-prologue.exp
--- gdb.arch/i386-prologue.exp	10 Aug 2006 05:27:19 -0000	1.12
+++ gdb.arch/i386-prologue.exp	20 Dec 2006 09:33:08 -0000
@@ -104,7 +104,6 @@ gdb_test "continue" \
 	"Breakpoint \[0-9\]*.*stack_align.*" \
 	"continue to stack_align + 7"
 
-setup_kfail *-*-* gdb/2080
 gdb_test "backtrace 10" \
 	"#0\[ \t\]*$hex in stack_align.*\r\n#1\[ \t\]*$hex in main.*" \
 	"first backtrace in stack_align"
@@ -115,12 +114,10 @@ gdb_test "continue" \
 
 skip_breakpoint stack_align
 
-setup_kfail *-*-* gdb/2080
 gdb_test "backtrace 10" \
 	"#0\[ \t\]*$hex in stack_align.*\r\n#1\[ \t\]*$hex in main.*" \
 	"second backtrace in stack_align"
 
-setup_kfail *-*-* gdb/2080
 gdb_test "info frame" \
 	".*Saved registers:.*ecx at.*ebp at.*edi at.*eip at.*" \
 	"saved registers in stack_align"

             reply	other threads:[~2006-12-20  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20  9:49 Joel Brobecker [this message]
2006-12-26 15:36 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061220095025.GE3640@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox