From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26822 invoked by alias); 20 Dec 2006 09:49:51 -0000 Received: (qmail 26812 invoked by uid 22791); 20 Dec 2006 09:49:50 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Dec 2006 09:49:41 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id D7F4748CE4E for ; Wed, 20 Dec 2006 04:49:39 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 01205-01-6 for ; Wed, 20 Dec 2006 04:49:39 -0500 (EST) Received: from takamaka.act-europe.fr (AStDenis-105-1-88-134.w80-8.abo.wanadoo.fr [80.8.217.134]) by nile.gnat.com (Postfix) with ESMTP id DB0E548CBCA for ; Wed, 20 Dec 2006 04:49:38 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 6B56534C099; Wed, 20 Dec 2006 13:50:25 +0400 (RET) Date: Wed, 20 Dec 2006 09:49:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [commit/testsuite] Remove breakpoint/2080 setup_kfail in i386-prologue.exp Message-ID: <20061220095025.GE3640@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="KDt/GgjP6HVcx58l" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00260.txt.bz2 --KDt/GgjP6HVcx58l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 744 Hello, I noticed some KPASS while running i386-prologue.exp. I looked a bit deeper, and it looks like the associated setup_kfail should be removed. They have always been there since the tests were added, but the bug they test was fixed almost at the same time... Testcase: http://www.sourceware.org/ml/gdb-patches/2006-02/msg00293.html Patch: http://www.sourceware.org/ml/gdb-patches/2006-02/msg00302.html 2006-12-20 Joel Brobecker * gdb.arch/i386-prologue.exp: Remove calls to setup_kfail. The associated tests should be PASSing. Tested on x86-linux. It seems pretty obvious, unless I missed something. Since it's easy to revert, I'll just apply the obvious rule and commit. Thanks, -- Joel --KDt/GgjP6HVcx58l Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="kfail.diff" Content-length: 1006 Index: gdb.arch/i386-prologue.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-prologue.exp,v retrieving revision 1.12 diff -u -p -r1.12 i386-prologue.exp --- gdb.arch/i386-prologue.exp 10 Aug 2006 05:27:19 -0000 1.12 +++ gdb.arch/i386-prologue.exp 20 Dec 2006 09:33:08 -0000 @@ -104,7 +104,6 @@ gdb_test "continue" \ "Breakpoint \[0-9\]*.*stack_align.*" \ "continue to stack_align + 7" -setup_kfail *-*-* gdb/2080 gdb_test "backtrace 10" \ "#0\[ \t\]*$hex in stack_align.*\r\n#1\[ \t\]*$hex in main.*" \ "first backtrace in stack_align" @@ -115,12 +114,10 @@ gdb_test "continue" \ skip_breakpoint stack_align -setup_kfail *-*-* gdb/2080 gdb_test "backtrace 10" \ "#0\[ \t\]*$hex in stack_align.*\r\n#1\[ \t\]*$hex in main.*" \ "second backtrace in stack_align" -setup_kfail *-*-* gdb/2080 gdb_test "info frame" \ ".*Saved registers:.*ecx at.*ebp at.*edi at.*eip at.*" \ "saved registers in stack_align" --KDt/GgjP6HVcx58l--