* gdb.base/break.c change
@ 2006-11-28 17:14 Daniel Jacobowitz
2006-11-28 17:55 ` Nathan Sidwell
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-11-28 17:14 UTC (permalink / raw)
To: Nathan Sidwell, gdb-patches
Hi Nathan,
Your break.c patch (fixing define.exp in some configuration) broke
break.exp. It's not expecting something between the start of main and
the first breakpoint, I think.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gdb.base/break.c change
2006-11-28 17:14 gdb.base/break.c change Daniel Jacobowitz
@ 2006-11-28 17:55 ` Nathan Sidwell
2006-11-28 18:10 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Sidwell @ 2006-11-28 17:55 UTC (permalink / raw)
To: Nathan Sidwell, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
Daniel Jacobowitz wrote:
> Hi Nathan,
>
> Your break.c patch (fixing define.exp in some configuration) broke
> break.exp. It's not expecting something between the start of main and
> the first breakpoint, I think.
oh fiddle sticks. I've committed this after verifying.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 1302 bytes --]
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.1283
diff -r1.1283 ChangeLog
0a1,4
> 2006-11-28 Nathan Sidwell <nathan@codesourcery.com>
>
> * gdb.base/break.c (main): Move position of malloc.
>
Index: gdb.base/break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
retrieving revision 1.24
diff -r1.24 break.exp
182a183,193
> verbose -log "Num Type\[ \]+Disp Enb Address\[ \]+What.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$main_line.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in marker2 at .*$srcfile1:($bp_location8|$bp_location9).*
> \[0-9\]+\[\t \]+breakpoint keep y.* in factorial$proto at .*$srcfile:$bp_location7.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location1.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location1.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location2.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in multi_line_if_conditional at .*$srcfile:$bp_location3.*
> \[0-9\]+\[\t \]+breakpoint keep y.* in multi_line_while_conditional at .*$srcfile:$bp_location4" \
> 2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gdb.base/break.c change
2006-11-28 17:55 ` Nathan Sidwell
@ 2006-11-28 18:10 ` Daniel Jacobowitz
2006-11-28 21:53 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-11-28 18:10 UTC (permalink / raw)
To: Nathan Sidwell; +Cc: gdb-patches
On Tue, Nov 28, 2006 at 05:55:01PM +0000, Nathan Sidwell wrote:
> Daniel Jacobowitz wrote:
> >Hi Nathan,
> >
> >Your break.c patch (fixing define.exp in some configuration) broke
> >break.exp. It's not expecting something between the start of main and
> >the first breakpoint, I think.
>
> oh fiddle sticks. I've committed this after verifying.
Wrong patch attached?
> retrieving revision 1.24
> diff -r1.24 break.exp
> 182a183,193
> > verbose -log "Num Type\[ \]+Disp Enb Address\[ \]+What.*
> > \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$main_line.*
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gdb.base/break.c change
2006-11-28 18:10 ` Daniel Jacobowitz
@ 2006-11-28 21:53 ` Daniel Jacobowitz
2006-11-29 8:03 ` Nathan Sidwell
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-11-28 21:53 UTC (permalink / raw)
To: Nathan Sidwell, gdb-patches
On Tue, Nov 28, 2006 at 01:09:45PM -0500, Daniel Jacobowitz wrote:
> On Tue, Nov 28, 2006 at 05:55:01PM +0000, Nathan Sidwell wrote:
> > Daniel Jacobowitz wrote:
> > >Hi Nathan,
> > >
> > >Your break.c patch (fixing define.exp in some configuration) broke
> > >break.exp. It's not expecting something between the start of main and
> > >the first breakpoint, I think.
> >
> > oh fiddle sticks. I've committed this after verifying.
>
> Wrong patch attached?
Wrong patch checked in; you added a verbose -log and didn't fix the
test. Bit late there by now, but could you check your working
directory tomorrow? Thanks in advance.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gdb.base/break.c change
2006-11-28 21:53 ` Daniel Jacobowitz
@ 2006-11-29 8:03 ` Nathan Sidwell
2006-11-29 14:02 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Sidwell @ 2006-11-29 8:03 UTC (permalink / raw)
To: Nathan Sidwell, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
Daniel Jacobowitz wrote:
> Wrong patch checked in; you added a verbose -log and didn't fix the
> test. Bit late there by now, but could you check your working
> directory tomorrow? Thanks in advance.
oh, what a pigs ear I made of that.
Here's what I've now checked in. No more checking in when I'm tired.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 1623 bytes --]
2006-11-29 Nathan Sidwell <nathan@codesourcery.com>
* gdb.base/break.c (main): Move position of malloc.
* gdb.base/break.exp: Revert mistaken checkin.
Index: gdb.base/break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
retrieving revision 1.25
diff -r1.25 break.exp
183,193d182
< verbose -log "Num Type\[ \]+Disp Enb Address\[ \]+What.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$main_line.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in marker2 at .*$srcfile1:($bp_location8|$bp_location9).*
< \[0-9\]+\[\t \]+breakpoint keep y.* in factorial$proto at .*$srcfile:$bp_location7.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location1.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location1.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location2.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in multi_line_if_conditional at .*$srcfile:$bp_location3.*
< \[0-9\]+\[\t \]+breakpoint keep y.* in multi_line_while_conditional at .*$srcfile:$bp_location4" \
< 2
<
Index: gdb.base/break.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.c,v
retrieving revision 1.6
diff -r1.6 break.c
90,93d89
< /* We're used by a test that requires malloc, so make sure it is
< in the executable. */
< (void)malloc (1);
<
103a100,103
> /* We're used by a test that requires malloc, so make sure it is
> in the executable. */
> (void)malloc (1);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gdb.base/break.c change
2006-11-29 8:03 ` Nathan Sidwell
@ 2006-11-29 14:02 ` Daniel Jacobowitz
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Jacobowitz @ 2006-11-29 14:02 UTC (permalink / raw)
To: Nathan Sidwell; +Cc: gdb-patches
On Wed, Nov 29, 2006 at 08:03:10AM +0000, Nathan Sidwell wrote:
> Daniel Jacobowitz wrote:
>
> >Wrong patch checked in; you added a verbose -log and didn't fix the
> >test. Bit late there by now, but could you check your working
> >directory tomorrow? Thanks in advance.
>
> oh, what a pigs ear I made of that.
>
> Here's what I've now checked in. No more checking in when I'm tired.
Thanks; passes now.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-11-29 14:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-11-28 17:14 gdb.base/break.c change Daniel Jacobowitz
2006-11-28 17:55 ` Nathan Sidwell
2006-11-28 18:10 ` Daniel Jacobowitz
2006-11-28 21:53 ` Daniel Jacobowitz
2006-11-29 8:03 ` Nathan Sidwell
2006-11-29 14:02 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox