From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7436 invoked by alias); 29 Nov 2006 08:03:21 -0000 Received: (qmail 7424 invoked by uid 22791); 29 Nov 2006 08:03:19 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Nov 2006 08:03:14 +0000 Received: (qmail 8123 invoked from network); 29 Nov 2006 08:03:12 -0000 Received: from unknown (HELO ?192.168.189.103?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Nov 2006 08:03:12 -0000 Message-ID: <456D3EBE.10205@codesourcery.com> Date: Wed, 29 Nov 2006 08:03:00 -0000 From: Nathan Sidwell User-Agent: Thunderbird 1.5.0.8 (X11/20061115) MIME-Version: 1.0 To: Nathan Sidwell , gdb-patches@sourceware.org Subject: Re: gdb.base/break.c change References: <20061128171012.GD21834@nevyn.them.org> <456C77F5.8030008@codesourcery.com> <20061128180945.GA25046@nevyn.them.org> <20061128215300.GA1674@nevyn.them.org> In-Reply-To: <20061128215300.GA1674@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------060305050101070202050102" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00369.txt.bz2 This is a multi-part message in MIME format. --------------060305050101070202050102 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 479 Daniel Jacobowitz wrote: > Wrong patch checked in; you added a verbose -log and didn't fix the > test. Bit late there by now, but could you check your working > directory tomorrow? Thanks in advance. oh, what a pigs ear I made of that. Here's what I've now checked in. No more checking in when I'm tired. nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk --------------060305050101070202050102 Content-Type: text/plain; name="all.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="all.diff" Content-length: 1623 2006-11-29 Nathan Sidwell * gdb.base/break.c (main): Move position of malloc. * gdb.base/break.exp: Revert mistaken checkin. Index: gdb.base/break.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v retrieving revision 1.25 diff -r1.25 break.exp 183,193d182 < verbose -log "Num Type\[ \]+Disp Enb Address\[ \]+What.* < \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$main_line.* < \[0-9\]+\[\t \]+breakpoint keep y.* in marker2 at .*$srcfile1:($bp_location8|$bp_location9).* < \[0-9\]+\[\t \]+breakpoint keep y.* in factorial$proto at .*$srcfile:$bp_location7.* < \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location1.* < \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location1.* < \[0-9\]+\[\t \]+breakpoint keep y.* in main at .*$srcfile:$bp_location2.* < \[0-9\]+\[\t \]+breakpoint keep y.* in multi_line_if_conditional at .*$srcfile:$bp_location3.* < \[0-9\]+\[\t \]+breakpoint keep y.* in multi_line_while_conditional at .*$srcfile:$bp_location4" \ < 2 < Index: gdb.base/break.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.c,v retrieving revision 1.6 diff -r1.6 break.c 90,93d89 < /* We're used by a test that requires malloc, so make sure it is < in the executable. */ < (void)malloc (1); < 103a100,103 > /* We're used by a test that requires malloc, so make sure it is > in the executable. */ > (void)malloc (1); > --------------060305050101070202050102--