Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nathan Sidwell <nathan@codesourcery.com>
To: Nathan Sidwell <nathan@codesourcery.com>,  gdb-patches@sourceware.org
Subject: Re: gdb.base/break.c change
Date: Wed, 29 Nov 2006 08:03:00 -0000	[thread overview]
Message-ID: <456D3EBE.10205@codesourcery.com> (raw)
In-Reply-To: <20061128215300.GA1674@nevyn.them.org>

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

Daniel Jacobowitz wrote:

> Wrong patch checked in; you added a verbose -log and didn't fix the
> test.  Bit late there by now, but could you check your working
> directory tomorrow?  Thanks in advance.

oh, what a pigs ear I made of that.

Here's what I've now checked in.  No more checking in when I'm tired.

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk


[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 1623 bytes --]

2006-11-29  Nathan Sidwell  <nathan@codesourcery.com>

	* gdb.base/break.c (main): Move position of malloc.
	* gdb.base/break.exp: Revert mistaken checkin.

Index: gdb.base/break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
retrieving revision 1.25
diff -r1.25 break.exp
183,193d182
< verbose -log    "Num Type\[ \]+Disp Enb Address\[ \]+What.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:$main_line.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in marker2 at .*$srcfile1:($bp_location8|$bp_location9).*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in factorial$proto at .*$srcfile:$bp_location7.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:$bp_location1.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:$bp_location1.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in main at .*$srcfile:$bp_location2.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in multi_line_if_conditional at .*$srcfile:$bp_location3.*
< \[0-9\]+\[\t \]+breakpoint     keep y.* in multi_line_while_conditional at .*$srcfile:$bp_location4" \
< 2
< 
Index: gdb.base/break.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.c,v
retrieving revision 1.6
diff -r1.6 break.c
90,93d89
<     /* We're used by a test that requires malloc, so make sure it is
<        in the executable.  */
<     (void)malloc (1);
< 
103a100,103
>     /* We're used by a test that requires malloc, so make sure it is
>        in the executable.  */
>     (void)malloc (1);
> 

  reply	other threads:[~2006-11-29  8:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-28 17:14 Daniel Jacobowitz
2006-11-28 17:55 ` Nathan Sidwell
2006-11-28 18:10   ` Daniel Jacobowitz
2006-11-28 21:53     ` Daniel Jacobowitz
2006-11-29  8:03       ` Nathan Sidwell [this message]
2006-11-29 14:02         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456D3EBE.10205@codesourcery.com \
    --to=nathan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox