[PATCH] Use bfd_vma for bfd addresses.

[PATCH] Use bfd_vma for bfd addresses.

[Thiemo Seufer]

Hello All,

the appended patch uses bfd_vma instead of SIM_ADDR for bfd addresses.
This prevents breaking the sign extension of addresses on mips.

Ok to apply?


Thiemo


2006-11-07  Thiemo Seufer  <ths@mips.com>

	* sim-base.h (text_start, text_end, start_addr): Use bfd_vma type
	for bfd text addresses.


Index: sim/common/sim-base.h
===================================================================
RCS file: /cvs/src/src/sim/common/sim-base.h,v
retrieving revision 1.5
diff -u -p -r1.5 sim-base.h
--- sim/common/sim-base.h	31 Oct 2003 05:32:46 -0000	1.5
+++ sim/common/sim-base.h	7 Nov 2006 13:08:31 -0000
@@ -181,13 +181,13 @@ typedef struct {
   /* The program's text section.  */
   struct bfd_section *text_section;
   /* Starting and ending text section addresses from the bfd.  */
-  SIM_ADDR text_start, text_end;
+  bfd_vma text_start, text_end;
 #define STATE_TEXT_SECTION(sd) ((sd)->base.text_section)
 #define STATE_TEXT_START(sd) ((sd)->base.text_start)
 #define STATE_TEXT_END(sd) ((sd)->base.text_end)
 
   /* Start address, set when the program is loaded from the bfd.  */
-  SIM_ADDR start_addr;
+  bfd_vma start_addr;
 #define STATE_START_ADDR(sd) ((sd)->base.start_addr)
 
   /* Size of the simulator's cache, if any.

Re: [PATCH] Use bfd_vma for bfd addresses.

[Daniel Jacobowitz]

On Tue, Nov 07, 2006 at 01:17:22PM +0000, Thiemo Seufer wrote:
> Hello All,
> 
> the appended patch uses bfd_vma instead of SIM_ADDR for bfd addresses.
> This prevents breaking the sign extension of addresses on mips.
> 
> Ok to apply?

What's the difference - is SIM_ADDR 32-bit?  A test case for this would
be nice if there isn't one already.

> 2006-11-07  Thiemo Seufer  <ths@mips.com>
> 
> 	* sim-base.h (text_start, text_end, start_addr): Use bfd_vma type
> 	for bfd text addresses.

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH] Use bfd_vma for bfd addresses.

[Thiemo Seufer]

Daniel Jacobowitz wrote:
> On Tue, Nov 07, 2006 at 01:17:22PM +0000, Thiemo Seufer wrote:
> > Hello All,
> > 
> > the appended patch uses bfd_vma instead of SIM_ADDR for bfd addresses.
> > This prevents breaking the sign extension of addresses on mips.
> > 
> > Ok to apply?
> 
> What's the difference - is SIM_ADDR 32-bit?

Yes.

> A test case for this would be nice if there isn't one already.

I'll see what I can come up with.


Thiemo