From: Daniel Jacobowitz <drow@false.org>
To: Frederic RISS <frederic.riss@st.com>
Cc: Andreas Schwab <schwab@suse.de>, gdb-patches@sources.redhat.com
Subject: Re: [RFC] New threadnum command for breakpoints
Date: Fri, 28 Jul 2006 15:14:00 -0000 [thread overview]
Message-ID: <20060728151434.GA17238@nevyn.them.org> (raw)
In-Reply-To: <1154098563.28300.282.camel@crx549.cro.st.com>
On Fri, Jul 28, 2006 at 04:56:03PM +0200, Frederic RISS wrote:
> * infrun.c detects breakpoint thread mismatch early and has code to
> handle thread hops correctly. This code won't be used in case the thread
> mismatch is detected only in the breakpoint condition. Couldn't that
> cause some problems? (If it's not an issue, we could certainly cleanup
> handle_inferior_event to remove that code)
It could probably be rearranged to only happen late.
> * I'm also a bit concerned about performance. Evaluating expressions is
> heavier that just comparing thread ids. At least in the context I use
> this functionality, the faster we resume, the better my system behaves.
> I haven't done any real profiling on this this point might be moot.
I really don't think this will be a problem. But if it is, we should
address it at its source - speed up the bottlenecks. An "if $thread
== 1" test shouldn't add much, since it doesn't have any target access.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-28 15:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 13:44 Frederic RISS
2006-07-28 14:03 ` Andreas Schwab
2006-07-28 14:13 ` Daniel Jacobowitz
2006-07-28 14:20 ` Andreas Schwab
2006-07-28 14:59 ` Frederic RISS
2006-07-28 15:14 ` Daniel Jacobowitz [this message]
2006-07-31 8:32 ` Frederic RISS
2006-07-31 12:53 ` Daniel Jacobowitz
2006-07-31 14:00 ` Frederic RISS
2006-07-31 20:07 ` Frédéric Riss
2006-07-31 20:14 ` Eli Zaretskii
2006-08-08 18:22 ` Daniel Jacobowitz
2006-08-08 19:43 ` Frédéric Riss
2006-08-16 14:15 ` Frederic RISS
2006-08-31 7:23 ` Frederic RISS
2006-07-28 14:28 ` Frederic RISS
2006-07-28 14:30 ` Frederic RISS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728151434.GA17238@nevyn.them.org \
--to=drow@false.org \
--cc=frederic.riss@st.com \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox