From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20168 invoked by alias); 28 Jul 2006 15:14:41 -0000 Received: (qmail 20159 invoked by uid 22791); 28 Jul 2006 15:14:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 28 Jul 2006 15:14:37 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G6U2s-0004Uo-QJ; Fri, 28 Jul 2006 11:14:34 -0400 Date: Fri, 28 Jul 2006 15:14:00 -0000 From: Daniel Jacobowitz To: Frederic RISS Cc: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: [RFC] New threadnum command for breakpoints Message-ID: <20060728151434.GA17238@nevyn.them.org> Mail-Followup-To: Frederic RISS , Andreas Schwab , gdb-patches@sources.redhat.com References: <1154093921.28300.236.camel@crx549.cro.st.com> <1154093921.28300.236.camel@crx549.cro.st.com> <20060728141339.GA15103@nevyn.them.org> <1154098563.28300.282.camel@crx549.cro.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1154098563.28300.282.camel@crx549.cro.st.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00420.txt.bz2 On Fri, Jul 28, 2006 at 04:56:03PM +0200, Frederic RISS wrote: > * infrun.c detects breakpoint thread mismatch early and has code to > handle thread hops correctly. This code won't be used in case the thread > mismatch is detected only in the breakpoint condition. Couldn't that > cause some problems? (If it's not an issue, we could certainly cleanup > handle_inferior_event to remove that code) It could probably be rearranged to only happen late. > * I'm also a bit concerned about performance. Evaluating expressions is > heavier that just comparing thread ids. At least in the context I use > this functionality, the faster we resume, the better my system behaves. > I haven't done any real profiling on this this point might be moot. I really don't think this will be a problem. But if it is, we should address it at its source - speed up the bottlenecks. An "if $thread == 1" test shouldn't add much, since it doesn't have any target access. -- Daniel Jacobowitz CodeSourcery