Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Frederic RISS <frederic.riss@st.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Andreas Schwab <schwab@suse.de>, gdb-patches@sources.redhat.com
Subject: Re: [RFC] New threadnum command for breakpoints
Date: Mon, 31 Jul 2006 14:00:00 -0000	[thread overview]
Message-ID: <1154354425.28300.335.camel@crx549.cro.st.com> (raw)
In-Reply-To: <20060731125311.GA1272@nevyn.them.org>

On Mon, 2006-07-31 at 08:53 -0400, Daniel Jacobowitz wrote:
> > I must be missing something. If thread hops have to be handled
> > separately, you must be able to distinguish a condition that indicates
> > 'wrong thread' from another that just says 'wrong condition', no?
> [..]
>
> I have the feeling we could treat "wrong thread" and "wrong condition"
> exactly identically, and everything would still work.

OK. I've got the same feeling, but given the complexity of the execution
control machinery I was reluctant to change it. 

bpstat_stop_status already checks for the thread match, so removing the
breakpoint_thread_match test in handle_inferior_event seems right and
should give us nearly identical code paths for thread tests carried out
using bp->thread or the $_gdb_thread variable. I'll follow up soon with
a patch doing this.

BTW, noone answered your request for comments about the variable name,
so I'll do the first iteration using $_gdb_thread.

Fred.


  reply	other threads:[~2006-07-31 14:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28 13:44 Frederic RISS
2006-07-28 14:03 ` Andreas Schwab
2006-07-28 14:13   ` Daniel Jacobowitz
2006-07-28 14:20     ` Andreas Schwab
2006-07-28 14:59     ` Frederic RISS
2006-07-28 15:14       ` Daniel Jacobowitz
2006-07-31  8:32         ` Frederic RISS
2006-07-31 12:53           ` Daniel Jacobowitz
2006-07-31 14:00             ` Frederic RISS [this message]
2006-07-31 20:07               ` Frédéric Riss
2006-07-31 20:14                 ` Eli Zaretskii
2006-08-08 18:22                 ` Daniel Jacobowitz
2006-08-08 19:43                   ` Frédéric Riss
2006-08-16 14:15                     ` Frederic RISS
2006-08-31  7:23                       ` Frederic RISS
2006-07-28 14:28   ` Frederic RISS
2006-07-28 14:30     ` Frederic RISS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1154354425.28300.335.camel@crx549.cro.st.com \
    --to=frederic.riss@st.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox