From: Daniel Jacobowitz <drow@false.org>
To: Roger Sayle <roger@eyesopen.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix IRIX compilation failure in solib-irix.c (take 2)
Date: Mon, 24 Jul 2006 22:03:00 -0000 [thread overview]
Message-ID: <20060724220350.GD18918@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0607241523040.22774-200000@www.eyesopen.com>
On Mon, Jul 24, 2006 at 03:29:36PM -0600, Roger Sayle wrote:
>
> Hi Dan,
>
> On Mon, 24 Jul 2006, Daniel Jacobowitz wrote:
> > Would it work to (A) add ".b" to the end of the expressions, and
> > (B) change gdb_int32_bytes and gdb_int64_bytes to use gdb_byte?
> > We try to avoid these casts; they're usually symptomatic of a type
> > problem elsewhere.
>
> Ah, clever. Yep, that fixes the build problem on IRIX for me.
> The following patch has been tested by building on mips-sgi-irix6.5.
> Many thanks for the suggestion.
>
>
> 2006-07-24 Roger Sayle <roger@eyesopen.com>
> Daniel Jacobowitz <dan@codesourcery.com>
>
> * solib-irix.c (gdb_int32_bytes): Use gdb_byte instead of char.
> (gdb_int64_bytes): Likewise.
> (fetch_lm_info): Use .b fields of gdb_int32_bytes and gdb_int64_bytes
> as first argument to extract_unsigned_integer to silence compiler
> warnings.
And thanks in turn for the patch. I've committed this.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2006-07-24 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 5:21 [PATCH] Fix IRIX compilation failure in solib-irix.c Roger Sayle
2006-07-24 20:07 ` Daniel Jacobowitz
2006-07-24 22:00 ` [PATCH] Fix IRIX compilation failure in solib-irix.c (take 2) Roger Sayle
2006-07-24 22:03 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724220350.GD18918@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=roger@eyesopen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox