Re: [PATCH] Fix IRIX compilation failure in solib-irix.c

Daniel Jacobowitz
2006-07-24T20:07:36Z

On Thu, Jul 20, 2006 at 10:52:21PM -0600, Roger Sayle wrote:
>
> Building mainline gdb on mips-sgi-irix6.5 during the compilation of
> gdb/solib-irix.c due to the interaction of -Werror and the compilation
> warnings caused by the implicit cases of the first argument in the
> calls to extract_unsigned_integer.
>
> The obvious fix is to cast the problematic arguments to gdb_byte*
> as expected by extract_unsigned_integer. This allows the build of
> gdb to complete without MIPS/IRIX.
>
> Ok for mainline? Although I have a gdb copyright assignment on file,
> I don't have write access to src, so I'd appreciate it if someone could
> commit this for me. Thanks in advance,

Would it work to (A) add ".b" to the end of the expressions, and
(B) change gdb_int32_bytes and gdb_int64_bytes to use gdb_byte?

We try to avoid these casts; they're usually symptomatic of a type
problem elsewhere.

--
Daniel Jacobowitz
CodeSourcery