Re: [PATCH] Fix IRIX compilation failure in solib-irix.c (take 2)

Daniel Jacobowitz
2006-07-24T22:03:54Z

On Mon, Jul 24, 2006 at 03:29:36PM -0600, Roger Sayle wrote:
>
> Hi Dan,
>
> On Mon, 24 Jul 2006, Daniel Jacobowitz wrote:
> > Would it work to (A) add ".b" to the end of the expressions, and
> > (B) change gdb_int32_bytes and gdb_int64_bytes to use gdb_byte?
> > We try to avoid these casts; they're usually symptomatic of a type
> > problem elsewhere.
>
> Ah, clever. Yep, that fixes the build problem on IRIX for me.
> The following patch has been tested by building on mips-sgi-irix6.5.
> Many thanks for the suggestion.
>
>
> 2006-07-24 Roger Sayle <roger@eyesopen.com>
> Daniel Jacobowitz <dan@codesourcery.com>
>
> * solib-irix.c (gdb_int32_bytes): Use gdb_byte instead of char.
> (gdb_int64_bytes): Likewise.
> (fetch_lm_info): Use .b fields of gdb_int32_bytes and gdb_int64_bytes
> as first argument to extract_unsigned_integer to silence compiler
> warnings.

And thanks in turn for the patch. I've committed this.

--
Daniel Jacobowitz
CodeSourcery