From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4014 invoked by alias); 24 Jul 2006 22:03:54 -0000 Received: (qmail 4005 invoked by uid 22791); 24 Jul 2006 22:03:54 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 24 Jul 2006 22:03:52 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G58Wk-00057d-2I; Mon, 24 Jul 2006 18:03:50 -0400 Date: Mon, 24 Jul 2006 22:03:00 -0000 From: Daniel Jacobowitz To: Roger Sayle Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix IRIX compilation failure in solib-irix.c (take 2) Message-ID: <20060724220350.GD18918@nevyn.them.org> Mail-Followup-To: Roger Sayle , gdb-patches@sourceware.org References: <20060724200731.GB15759@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00372.txt.bz2 On Mon, Jul 24, 2006 at 03:29:36PM -0600, Roger Sayle wrote: > > Hi Dan, > > On Mon, 24 Jul 2006, Daniel Jacobowitz wrote: > > Would it work to (A) add ".b" to the end of the expressions, and > > (B) change gdb_int32_bytes and gdb_int64_bytes to use gdb_byte? > > We try to avoid these casts; they're usually symptomatic of a type > > problem elsewhere. > > Ah, clever. Yep, that fixes the build problem on IRIX for me. > The following patch has been tested by building on mips-sgi-irix6.5. > Many thanks for the suggestion. > > > 2006-07-24 Roger Sayle > Daniel Jacobowitz > > * solib-irix.c (gdb_int32_bytes): Use gdb_byte instead of char. > (gdb_int64_bytes): Likewise. > (fetch_lm_info): Use .b fields of gdb_int32_bytes and gdb_int64_bytes > as first argument to extract_unsigned_integer to silence compiler > warnings. And thanks in turn for the patch. I've committed this. -- Daniel Jacobowitz CodeSourcery