From: Daniel Jacobowitz <drow@false.org>
To: Roger Sayle <roger@eyesopen.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix IRIX compilation failure in solib-irix.c
Date: Mon, 24 Jul 2006 20:07:00 -0000 [thread overview]
Message-ID: <20060724200731.GB15759@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0607202243320.5416-100000@www.eyesopen.com>
On Thu, Jul 20, 2006 at 10:52:21PM -0600, Roger Sayle wrote:
>
> Building mainline gdb on mips-sgi-irix6.5 during the compilation of
> gdb/solib-irix.c due to the interaction of -Werror and the compilation
> warnings caused by the implicit cases of the first argument in the
> calls to extract_unsigned_integer.
>
> The obvious fix is to cast the problematic arguments to gdb_byte*
> as expected by extract_unsigned_integer. This allows the build of
> gdb to complete without MIPS/IRIX.
>
> Ok for mainline? Although I have a gdb copyright assignment on file,
> I don't have write access to src, so I'd appreciate it if someone could
> commit this for me. Thanks in advance,
Would it work to (A) add ".b" to the end of the expressions, and
(B) change gdb_int32_bytes and gdb_int64_bytes to use gdb_byte?
We try to avoid these casts; they're usually symptomatic of a type
problem elsewhere.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-24 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 5:21 Roger Sayle
2006-07-24 20:07 ` Daniel Jacobowitz [this message]
2006-07-24 22:00 ` [PATCH] Fix IRIX compilation failure in solib-irix.c (take 2) Roger Sayle
2006-07-24 22:03 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724200731.GB15759@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=roger@eyesopen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox