From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27294 invoked by alias); 24 Jul 2006 20:07:36 -0000 Received: (qmail 27282 invoked by uid 22791); 24 Jul 2006 20:07:35 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 24 Jul 2006 20:07:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G56iB-0004BT-Ph; Mon, 24 Jul 2006 16:07:32 -0400 Date: Mon, 24 Jul 2006 20:07:00 -0000 From: Daniel Jacobowitz To: Roger Sayle Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix IRIX compilation failure in solib-irix.c Message-ID: <20060724200731.GB15759@nevyn.them.org> Mail-Followup-To: Roger Sayle , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00347.txt.bz2 On Thu, Jul 20, 2006 at 10:52:21PM -0600, Roger Sayle wrote: > > Building mainline gdb on mips-sgi-irix6.5 during the compilation of > gdb/solib-irix.c due to the interaction of -Werror and the compilation > warnings caused by the implicit cases of the first argument in the > calls to extract_unsigned_integer. > > The obvious fix is to cast the problematic arguments to gdb_byte* > as expected by extract_unsigned_integer. This allows the build of > gdb to complete without MIPS/IRIX. > > Ok for mainline? Although I have a gdb copyright assignment on file, > I don't have write access to src, so I'd appreciate it if someone could > commit this for me. Thanks in advance, Would it work to (A) add ".b" to the end of the expressions, and (B) change gdb_int32_bytes and gdb_int64_bytes to use gdb_byte? We try to avoid these casts; they're usually symptomatic of a type problem elsewhere. -- Daniel Jacobowitz CodeSourcery